[clang][bytecode] Create InterpState allocator on demand #158802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We often don't need it (especially in C), so make this optional and create it only when we first allocate something.
llvmbot added clang 
Member
| @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) ChangesWe often don't need it (especially in C), so make this optional and create it only when we first allocate something. Full diff: https://github.com/llvm/llvm-project/pull/158802.diff 1 Files Affected:
diff --git a/clang/lib/AST/ByteCode/InterpState.h b/clang/lib/AST/ByteCode/InterpState.h index e095908bce986..4e1b9aec09099 100644 --- a/clang/lib/AST/ByteCode/InterpState.h +++ b/clang/lib/AST/ByteCode/InterpState.h @@ -122,7 +122,9 @@ class InterpState final : public State, public SourceMapper { StdAllocatorCaller getStdAllocatorCaller(StringRef Name) const; void *allocate(size_t Size, unsigned Align = 8) const { - return Allocator.Allocate(Size, Align); + if (!Allocator) + Allocator.emplace(); + return Allocator->Allocate(Size, Align); } template <typename T> T *allocate(size_t Num = 1) const { return static_cast<T *>(allocate(Num * sizeof(T), alignof(T))); @@ -188,7 +190,7 @@ class InterpState final : public State, public SourceMapper { /// for. llvm::SmallVector<const Block *> InitializingBlocks; - mutable llvm::BumpPtrAllocator Allocator; + mutable std::optional<llvm::BumpPtrAllocator> Allocator; }; class InterpStateCCOverride final { |
Collaborator
| LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/13563 Here is the relevant piece of the build log for the reference |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We often don't need it (especially in C), so make this optional and create it only when we first allocate something.