[mlir] Replace LLVM_ATTRIBUTE_UNUSED with [[maybe_unused]] (NFC) #163917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This patch replaces LLVM_ATTRIBUTE_UNUSED with [[maybe_unused]], introduced as part of C++17.
kazutakahirata requested review from PeimingLiu and yinying-lisa-li as code owners 
Member
| @llvm/pr-subscribers-mlir-sparse Author: Kazu Hirata (kazutakahirata) ChangesThis patch replaces LLVM_ATTRIBUTE_UNUSED with [[maybe_unused]], Full diff: https://github.com/llvm/llvm-project/pull/163917.diff 1 Files Affected:
diff --git a/mlir/unittests/Dialect/SparseTensor/MergerTest.cpp b/mlir/unittests/Dialect/SparseTensor/MergerTest.cpp index 2a583059d2e0a..2b92e47d9288e 100644 --- a/mlir/unittests/Dialect/SparseTensor/MergerTest.cpp +++ b/mlir/unittests/Dialect/SparseTensor/MergerTest.cpp @@ -141,7 +141,7 @@ class MergerTestBase : public ::testing::TestWithParam<LevelFormat> { } #define IMPL_BINOP_EXPR(OP, KIND) \ - LLVM_ATTRIBUTE_UNUSED ExprId OP##Expr(ExprId e0, ExprId e1) { \ + [[maybe_unused]] ExprId OP##Expr(ExprId e0, ExprId e1) { \ return merger.addExp(KIND, e0, e1); \ } FOREVERY_BINOP(IMPL_BINOP_EXPR) |
Member
| @llvm/pr-subscribers-mlir Author: Kazu Hirata (kazutakahirata) ChangesThis patch replaces LLVM_ATTRIBUTE_UNUSED with [[maybe_unused]], Full diff: https://github.com/llvm/llvm-project/pull/163917.diff 1 Files Affected:
diff --git a/mlir/unittests/Dialect/SparseTensor/MergerTest.cpp b/mlir/unittests/Dialect/SparseTensor/MergerTest.cpp index 2a583059d2e0a..2b92e47d9288e 100644 --- a/mlir/unittests/Dialect/SparseTensor/MergerTest.cpp +++ b/mlir/unittests/Dialect/SparseTensor/MergerTest.cpp @@ -141,7 +141,7 @@ class MergerTestBase : public ::testing::TestWithParam<LevelFormat> { } #define IMPL_BINOP_EXPR(OP, KIND) \ - LLVM_ATTRIBUTE_UNUSED ExprId OP##Expr(ExprId e0, ExprId e1) { \ + [[maybe_unused]] ExprId OP##Expr(ExprId e0, ExprId e1) { \ return merger.addExp(KIND, e0, e1); \ } FOREVERY_BINOP(IMPL_BINOP_EXPR) |
tgymnich approved these changes Oct 17, 2025
kuhar approved these changes Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This patch replaces LLVM_ATTRIBUTE_UNUSED with [[maybe_unused]],
introduced as part of C++17.