[NFC][doc] Mark P1857R3 as partial implemented #164095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: yronglin <yronglin777@gmail.com>
yronglin requested review from Bigcheese, ChuanqiXu9, cor3ntin and hubert-reinterpretcast 
Member
| @llvm/pr-subscribers-clang Author: None (yronglin) ChangesSince the following 2 patches was landed, mark P1857R3 as partial implemented.
Full diff: https://github.com/llvm/llvm-project/pull/164095.diff 1 Files Affected:
diff --git a/clang/www/cxx_status.html b/clang/www/cxx_status.html index a35e50150a2ab..9f4287b68d9ef 100755 --- a/clang/www/cxx_status.html +++ b/clang/www/cxx_status.html @@ -926,7 +926,14 @@ <h2 id="cxx20">C++20 implementation status</h2> </tr> <tr> <td><a href="https://wg21.link/p1857r3">P1857R3</a></td> - <td class="none" align="center">No</td> + <td class="partial" align="center"> + <details> + <summary>>Clang 21(Partial)</summary> + The restriction 'A module directive may only appear as + the first preprocessing tokens in a file' was supported + in clang-21. + </details> + </td> </tr> <tr> <td><a href="https://wg21.link/p2115r0">P2115R0</a></td> |
h-vetinari reviewed Oct 19, 2025
hubert-reinterpretcast approved these changes Oct 19, 2025
Collaborator
hubert-reinterpretcast left a comment
hubert-reinterpretcast left a comment There was a problem hiding this comment.
LGTM once comments are addressed.
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
Co-authored-by: Hubert Tong <hubert.reinterpretcast@gmail.com>
ChuanqiXu9 approved these changes Oct 20, 2025
Member
ChuanqiXu9 left a comment
ChuanqiXu9 left a comment There was a problem hiding this comment.
Out of curiosity, which parts are not implemented?
Contributor Author
All the rest parts will be supported in #107168. 🤣 |
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
Since the following 2 patches was landed, mark P1857R3 as partial implemented. - [[C++][Modules] A module directive may only appear as the first preprocessing tokens in a file](llvm#144233). - [[clang] Allow trivial pp-directives before C++ module directive](llvm#153641). --------- Signed-off-by: yronglin <yronglin777@gmail.com> Co-authored-by: h-vetinari <h.vetinari@gmx.com> Co-authored-by: Hubert Tong <hubert.reinterpretcast@gmail.com>
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
Since the following 2 patches was landed, mark P1857R3 as partial implemented. - [[C++][Modules] A module directive may only appear as the first preprocessing tokens in a file](llvm#144233). - [[clang] Allow trivial pp-directives before C++ module directive](llvm#153641). --------- Signed-off-by: yronglin <yronglin777@gmail.com> Co-authored-by: h-vetinari <h.vetinari@gmx.com> Co-authored-by: Hubert Tong <hubert.reinterpretcast@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since the following 2 patches was landed, mark P1857R3 as partial implemented.