[lldb-dap] use workspaceFolder in vscode configurations. #164320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`workspaceRoot` was deprecated in [september 2017 release](https://code.visualstudio.com/updates/v1_17#_workspacefolder-in-launchjson-and-tasksjson)
Member
| @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes
Full diff: https://github.com/llvm/llvm-project/pull/164320.diff 1 Files Affected:
diff --git a/lldb/tools/lldb-dap/package.json b/lldb/tools/lldb-dap/package.json index 3f0f150c0d98e..05dce285dd592 100644 --- a/lldb/tools/lldb-dap/package.json +++ b/lldb/tools/lldb-dap/package.json @@ -453,7 +453,7 @@ "cwd": { "type": "string", "description": "Program working directory.", - "default": "${workspaceRoot}" + "default": "${workspaceFolder}" }, "env": { "anyOf": [ @@ -883,10 +883,10 @@ "type": "lldb-dap", "request": "launch", "name": "Debug", - "program": "${workspaceRoot}/<your program>", + "program": "${workspaceFolder}/<your program>", "args": [], "env": [], - "cwd": "${workspaceRoot}" + "cwd": "${workspaceFolder}" } ], "configurationSnippets": [ @@ -897,10 +897,10 @@ "type": "lldb-dap", "request": "launch", "name": "${2:Launch}", - "program": "^\"\\${workspaceRoot}/${1:<your program>}\"", + "program": "^\"\\${workspaceFolder}/${1:<your program>}\"", "args": [], "env": [], - "cwd": "^\"\\${workspaceRoot}\"" + "cwd": "^\"\\${workspaceFolder}\"" } }, { |
JDevlieghere approved these changes Oct 20, 2025
Collaborator
| LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/33599 Here is the relevant piece of the build log for the reference |
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
`workspaceRoot` was deprecated in [september 2017 release](https://code.visualstudio.com/updates/v1_17#_workspacefolder-in-launchjson-and-tasksjson)
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
`workspaceRoot` was deprecated in [september 2017 release](https://code.visualstudio.com/updates/v1_17#_workspacefolder-in-launchjson-and-tasksjson)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
workspaceRootwas deprecated in september 2017 release