Skip to content

Conversation

@paperchalice
Copy link
Contributor

This should be the last use in clang.

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:codegen IR generation bugs: mangling, exceptions, etc. labels Oct 22, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 22, 2025

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-clang-codegen

Author: None (paperchalice)

Changes

This should be the last use in clang.


Full diff: https://github.com/llvm/llvm-project/pull/164525.diff

1 Files Affected:

  • (modified) clang/lib/CodeGen/BackendUtil.cpp (-6)
diff --git a/clang/lib/CodeGen/BackendUtil.cpp b/clang/lib/CodeGen/BackendUtil.cpp index 602068436101b..ecfbcb5970092 100644 --- a/clang/lib/CodeGen/BackendUtil.cpp +++ b/clang/lib/CodeGen/BackendUtil.cpp @@ -430,12 +430,6 @@ static bool initTargetOptions(const CompilerInstance &CI, Options.NoInfsFPMath = LangOpts.NoHonorInfs; Options.NoNaNsFPMath = LangOpts.NoHonorNaNs; Options.NoZerosInBSS = CodeGenOpts.NoZeroInitializedInBSS; - Options.UnsafeFPMath = LangOpts.AllowFPReassoc && LangOpts.AllowRecip && - LangOpts.NoSignedZero && LangOpts.ApproxFunc && - (LangOpts.getDefaultFPContractMode() == - LangOptions::FPModeKind::FPM_Fast || - LangOpts.getDefaultFPContractMode() == - LangOptions::FPModeKind::FPM_FastHonorPragmas); Options.BBAddrMap = CodeGenOpts.BBAddrMap; Options.BBSections = 
@paperchalice paperchalice merged commit bc7e3ff into llvm:main Oct 22, 2025
13 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Oct 22, 2025

LLVM Buildbot has detected a new failure on builder clang-aarch64-sve-vla-2stage running on linaro-g3-04 while building clang at step 12 "ninja check 2".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/41/builds/9791

Here is the relevant piece of the build log for the reference
Step 12 (ninja check 2) failure: stage 2 checked (failure) ******************** TEST 'MemorySanitizer-AARCH64 :: release_origin.c' FAILED ******************** Exit Code: 1 Command Output (stderr): -- /home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/stage2/./bin/clang -fsanitize=memory -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -gline-tables-only -fsanitize-memory-track-origins=0 -O0 /home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/llvm/compiler-rt/test/msan/release_origin.c -o /home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/stage2/runtimes/runtimes-bins/compiler-rt/test/msan/AARCH64/Output/release_origin.c.tmp && env MSAN_OPTIONS=soft_rss_limit_mb=18:verbosity=1:allocator_may_return_null=1 /home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/stage2/runtimes/runtimes-bins/compiler-rt/test/msan/AARCH64/Output/release_origin.c.tmp 2>&1 | FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/llvm/compiler-rt/test/msan/release_origin.c -implicit-check-not="soft rss limit" -check-prefixes=CHECK,NOORIG # RUN: at line 1 + /home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/stage2/./bin/clang -fsanitize=memory -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -gline-tables-only -fsanitize-memory-track-origins=0 -O0 /home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/llvm/compiler-rt/test/msan/release_origin.c -o /home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/stage2/runtimes/runtimes-bins/compiler-rt/test/msan/AARCH64/Output/release_origin.c.tmp + FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/llvm/compiler-rt/test/msan/release_origin.c '-implicit-check-not=soft rss limit' -check-prefixes=CHECK,NOORIG + env MSAN_OPTIONS=soft_rss_limit_mb=18:verbosity=1:allocator_may_return_null=1 /home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/stage2/runtimes/runtimes-bins/compiler-rt/test/msan/AARCH64/Output/release_origin.c.tmp /home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/llvm/compiler-rt/test/msan/release_origin.c:42:12: error: NOORIG: expected string not found in input // NOORIG: soft rss limit unexhausted ^ <stdin>:94:5: note: scanning from here free ^ Input file: <stdin> Check file: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/llvm/compiler-rt/test/msan/release_origin.c -dump-input=help explains the following input dump. Input was: <<<<<< . . . 89: MemorySanitizer: RSS: 23Mb 90: MemorySanitizer: StackDepot: 0 ids; 0M allocated 91: ==3440194==MemorySanitizer: soft rss limit exhausted (18Mb vs 23Mb) 92: memset 93: MemorySanitizer: RSS: 33Mb 94: free check:42 X error: no match found >>>>>> -- ******************** 
@paperchalice paperchalice deleted the clang-unsafe-fp-math branch October 22, 2025 08:26
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:codegen IR generation bugs: mangling, exceptions, etc. clang Clang issues not falling into any other category

4 participants