[mlir][IR] Deprecate OpBuilder::create in favor of free functions #164649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kuhar requested review from jpienaar, krzysz00, makslevental and matthias-springer 
Member
| @llvm/pr-subscribers-flang-openmp @llvm/pr-subscribers-mlir Author: Jakub Kuderski (kuhar) ChangesThese have been soft-deprecated since July: https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339 Add a deprecation attribute to prevent new uses from creeping in. Full diff: https://github.com/llvm/llvm-project/pull/164649.diff 1 Files Affected:
diff --git a/mlir/include/mlir/IR/Builders.h b/mlir/include/mlir/IR/Builders.h index 9205f16f97bbb..3ba6818204ba0 100644 --- a/mlir/include/mlir/IR/Builders.h +++ b/mlir/include/mlir/IR/Builders.h @@ -502,6 +502,7 @@ class OpBuilder : public Builder { public: /// Create an operation of specific op type at the current insertion point. template <typename OpTy, typename... Args> + [[deprecated("Use OpTy::create instead")]] OpTy create(Location location, Args &&...args) { OperationState state(location, getCheckRegisteredInfo<OpTy>(location.getContext())); @@ -517,9 +518,9 @@ class OpBuilder : public Builder { /// the results of the operation. /// /// Note: This performs opportunistic eager folding during IR construction. - /// The folders are designed to operate efficiently on canonical IR, which + /// The folders are designed to operate efficiently on canonical IR, which /// this API does not enforce. Complete folding isn't only expected in the - /// context of canonicalization which intertwine folders with pattern + /// context of canonicalization which intertwine folders with pattern /// rewrites until fixed-point. template <typename OpTy, typename... Args> void createOrFold(SmallVectorImpl<Value> &results, Location location, |
Member
| @llvm/pr-subscribers-mlir-core Author: Jakub Kuderski (kuhar) ChangesThese have been soft-deprecated since July: https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339 Add a deprecation attribute to prevent new uses from creeping in. Full diff: https://github.com/llvm/llvm-project/pull/164649.diff 1 Files Affected:
diff --git a/mlir/include/mlir/IR/Builders.h b/mlir/include/mlir/IR/Builders.h index 9205f16f97bbb..3ba6818204ba0 100644 --- a/mlir/include/mlir/IR/Builders.h +++ b/mlir/include/mlir/IR/Builders.h @@ -502,6 +502,7 @@ class OpBuilder : public Builder { public: /// Create an operation of specific op type at the current insertion point. template <typename OpTy, typename... Args> + [[deprecated("Use OpTy::create instead")]] OpTy create(Location location, Args &&...args) { OperationState state(location, getCheckRegisteredInfo<OpTy>(location.getContext())); @@ -517,9 +518,9 @@ class OpBuilder : public Builder { /// the results of the operation. /// /// Note: This performs opportunistic eager folding during IR construction. - /// The folders are designed to operate efficiently on canonical IR, which + /// The folders are designed to operate efficiently on canonical IR, which /// this API does not enforce. Complete folding isn't only expected in the - /// context of canonicalization which intertwine folders with pattern + /// context of canonicalization which intertwine folders with pattern /// rewrites until fixed-point. template <typename OpTy, typename... Args> void createOrFold(SmallVectorImpl<Value> &results, Location location, |
Contributor
| No objections here |
makslevental approved these changes Oct 22, 2025
Member Author
| I forgot I also need to update flang and clang -- will send out separate PRs for these |
This was referenced Oct 22, 2025
Member Author
kuhar added a commit that referenced this pull request Oct 22, 2025
See https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339. I plan to mark these as deprecated in #164649.
dcaballe approved these changes Oct 22, 2025
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Oct 22, 2025
…657) See https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339. I plan to mark these as deprecated in llvm/llvm-project#164649.
kuhar added a commit that referenced this pull request Oct 22, 2025
See https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339. I plan to make these deprecated in #164649.
kuhar force-pushed the deprecate-create-method branch from 49ff0d7 to 6a20de7 Compare Member Author
| Rebased. Clang and Flang changes landed. |
Member Author
| Fixed new uses in OpenMP... |
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Oct 22, 2025
…(#164656) See https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339. I plan to make these deprecated in llvm/llvm-project#164649.
dvbuka pushed a commit to dvbuka/llvm-project that referenced this pull request Oct 27, 2025
See https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339. I plan to mark these as deprecated in llvm#164649.
dvbuka pushed a commit to dvbuka/llvm-project that referenced this pull request Oct 27, 2025
See https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339. I plan to make these deprecated in llvm#164649.
dvbuka pushed a commit to dvbuka/llvm-project that referenced this pull request Oct 27, 2025
…lvm#164649) These have been soft-deprecated since July: https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339 Add a deprecation attribute to prevent new uses from creeping in.
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
See https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339. I plan to mark these as deprecated in llvm#164649.
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
See https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339. I plan to make these deprecated in llvm#164649.
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
…lvm#164649) These have been soft-deprecated since July: https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339 Add a deprecation attribute to prevent new uses from creeping in.
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
See https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339. I plan to mark these as deprecated in llvm#164649.
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
See https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339. I plan to make these deprecated in llvm#164649.
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
…lvm#164649) These have been soft-deprecated since July: https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339 Add a deprecation attribute to prevent new uses from creeping in.
Yu-Zhewen added a commit to iree-org/llvm-project that referenced this pull request Nov 5, 2025
…ctions (llvm#164649)" This reverts commit c0b42ec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These have been soft-deprecated since July: https://discourse.llvm.org/t/psa-opty-create-now-with-100-more-tab-complete/87339
Add a deprecation attribute to prevent new uses from creeping in.