[lldb][NFC] Remove code dupl in favour of a named variable in UnwindAssemblyInstEmulation #169369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ssemblyInstEmulation
Member
| @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) ChangesFull diff: https://github.com/llvm/llvm-project/pull/169369.diff 1 Files Affected:
diff --git a/lldb/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp b/lldb/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp index b6b073a96bcad..4da09adba787b 100644 --- a/lldb/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp +++ b/lldb/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp @@ -212,11 +212,10 @@ bool UnwindAssemblyInstEmulation::GetNonCallSiteUnwindPlanFromAssembly( if (m_curr_row_modified) { // Save the modified row if we don't already have a CFI row in the // current address - if (saved_unwind_states.count(current_offset + - inst->GetOpcode().GetByteSize()) == 0) { - m_state.row.SetOffset(current_offset + inst->GetOpcode().GetByteSize()); - saved_unwind_states.emplace( - current_offset + inst->GetOpcode().GetByteSize(), m_state); + auto next_inst_offset = current_offset + inst->GetOpcode().GetByteSize(); + if (saved_unwind_states.count(next_inst_offset) == 0) { + m_state.row.SetOffset(next_inst_offset); + saved_unwind_states.emplace(next_inst_offset, m_state); } } } |
da-viper reviewed Nov 24, 2025
| m_state.row.SetOffset(current_offset + inst->GetOpcode().GetByteSize()); | ||
| saved_unwind_states.emplace( | ||
| current_offset + inst->GetOpcode().GetByteSize(), m_state); | ||
| auto next_inst_offset = current_offset + inst->GetOpcode().GetByteSize(); |
Contributor
There was a problem hiding this comment.
use const type instead of auto.
Contributor Author
There was a problem hiding this comment.
sad, but it is the guideline
da-viper approved these changes Nov 25, 2025
felipepiovezan deleted the felipe/gc_lldbnfc_remove_code_dupl_in_favour_of_a_named_variable_in_unwindassemblyinstemulation_24yef branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.