Skip to content

[clang][NFC] Don't copy into a vector just to iterate in IsInitListMemberExprInitialized #169385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

[clang][NFC] Don't copy into a vector just to iterate in IsInitListMemberExprInitialized #169385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions clang/lib/Sema/SemaDeclCXX.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3782,21 +3782,21 @@ namespace {
if (CheckReferenceOnly && !ReferenceField)
return true;

llvm::SmallVector<unsigned, 4> UsedFieldIndex;
// Discard the first field since it is the field decl that is being
// initialized.
for (const FieldDecl *FD : llvm::drop_begin(llvm::reverse(Fields)))
UsedFieldIndex.push_back(FD->getFieldIndex());

for (auto UsedIter = UsedFieldIndex.begin(),
UsedEnd = UsedFieldIndex.end(),
OrigIter = InitFieldIndex.begin(),
OrigEnd = InitFieldIndex.end();
UsedIter != UsedEnd && OrigIter != OrigEnd; ++UsedIter, ++OrigIter) {
if (*UsedIter < *OrigIter)
auto UsedFields = llvm::drop_begin(llvm::reverse(Fields));
auto UsedIter = UsedFields.begin();
const auto UsedEnd = UsedFields.end();

for (const unsigned Orig : InitFieldIndex) {
if (UsedIter == UsedEnd)
break;
const unsigned UsedIndex = (*UsedIter)->getFieldIndex();
if (UsedIndex < Orig)
return true;
if (*UsedIter > *OrigIter)
if (UsedIndex > Orig)
break;
++UsedIter;
}

return false;
Expand Down