Skip to content

Conversation

@gbMattN
Copy link
Contributor

@gbMattN gbMattN commented Nov 28, 2025

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Nov 28, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Matthew Nagy (gbMattN)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/169934.diff

1 Files Affected:

  • (modified) compiler-rt/test/ubsan/TestCases/Misc/Posix/print_stack_trace.cpp (+3)
diff --git a/compiler-rt/test/ubsan/TestCases/Misc/Posix/print_stack_trace.cpp b/compiler-rt/test/ubsan/TestCases/Misc/Posix/print_stack_trace.cpp index 2eac710d98085..c5c8eb7853458 100644 --- a/compiler-rt/test/ubsan/TestCases/Misc/Posix/print_stack_trace.cpp +++ b/compiler-rt/test/ubsan/TestCases/Misc/Posix/print_stack_trace.cpp @@ -4,6 +4,9 @@ // This test is temporarily disabled due to broken unwinding on ARM. // UNSUPPORTED: target={{.*-linux-.*}} +// Temporarily unsupporting on TySan until interfaces are implemented +// UNSUPPORTED: ubsan-tysan + // The test doesn't pass on Darwin in UBSan-TSan configuration, because TSan is // using the slow unwinder which is not supported on Darwin. The test should // be universal after landing of https://reviews.llvm.org/D32806. 
@gbMattN
Copy link
Contributor Author

gbMattN commented Nov 28, 2025

Grepping in UBSan tests for #include <sanitizer/common_interface_defs.h., it looks like this is the only ubsan test that uses the interfaces, so this should be it

Copy link
Contributor

@cofibrant cofibrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Could you just add [TySan](TestOnly) or similar to the PR title?

@gbMattN gbMattN changed the title Mark ubsan-tysan test as unsupported for now [TySan](test-only) Mark ubsan-tysan test as unsupported for now Nov 28, 2025
@gbMattN gbMattN enabled auto-merge (squash) November 28, 2025 16:23
@gbMattN gbMattN merged commit 8c31b12 into llvm:main Nov 28, 2025
14 checks passed
aahrun pushed a commit to aahrun/llvm-project that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants