Skip to content

Conversation

@PiotrZSL
Copy link
Member

@PiotrZSL PiotrZSL commented Sep 2, 2023

In C struct are visible as RecordDecl, not as CXXRecordDecl, this type of declaration were not supported in this check before. Changing check to support it. Added tests.

Fixes: #55422

…Case in C In C struct are visible as RecordDecl, not as CXXRecordDecl, this type of declaration were not supported in this check before. Changing check to support it. Added tests. Fixes: llvm#55422
@PiotrZSL PiotrZSL requested a review from a team as a code owner September 2, 2023 08:05
Copy link
Contributor

@carlosgalvezp carlosgalvezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PiotrZSL PiotrZSL merged commit fa8e740 into llvm:main Sep 3, 2023
@PiotrZSL PiotrZSL deleted the 55422-readability-identifier-namingstructcase-not-working-for-c-file branch September 3, 2023 16:40
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
…Case in C (llvm#65202) In C struct are visible as RecordDecl, not as CXXRecordDecl, this type of declaration were not supported in this check before. Changing check to support it. Added tests. Fixes: llvm#55422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants