Skip to content

[flang][openacc] Lower acc cache directive #65673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2023
Merged

[flang][openacc] Lower acc cache directive #65673

merged 3 commits into from
Sep 11, 2023

Conversation

@clementval
Copy link
Contributor

@clementval clementval commented Sep 7, 2023 •
edited
Loading

The cache directive is attached directly to the acc.loop operation when the directive appears in the loop. When it appears before a loop, the OpenACCCacheConstruct is saved and attached when the acc.loop is created.

Directive that cannot be attached to a loop are silently discarded.

Depends on #65521
@clementval clementval requested a review from a team as a code owner September 7, 2023 21:02
@github-actions github-actions bot added the flang Flang issues not falling into any other category label Sep 7, 2023
razvanlupusoru
razvanlupusoru approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@razvanlupusoru razvanlupusoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
@clementval clementval merged commit 8bc676c into llvm:main Sep 11, 2023
@clementval clementval deleted the acc_cache_lowering branch September 11, 2023 20:38
AntonRydahl pushed a commit to AntonRydahl/llvm-project that referenced this pull request Sep 11, 2023
@clementval @AntonRydahl
[flang][openacc] Lower acc cache directive (llvm#65673)
770fcc9 
The cache directive is attached directly to the acc.loop operation when the directive appears in the loop. When it appears before a loop, the OpenACCCacheConstruct is saved and attached when the acc.loop is created. Directive that cannot be attached to a loop are silently discarded. Depends on llvm#65521
@vzakhari vzakhari mentioned this pull request Sep 12, 2023
Closed
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
@clementval @ZijunZhaoCCK
[flang][openacc] Lower acc cache directive (llvm#65673)
f840342 
The cache directive is attached directly to the acc.loop operation when the directive appears in the loop. When it appears before a loop, the OpenACCCacheConstruct is saved and attached when the acc.loop is created. Directive that cannot be attached to a loop are silently discarded. Depends on llvm#65521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flang Flang issues not falling into any other category openacc

2 participants

@clementval @razvanlupusoru