[mlir][linalg][transform][python] Drop _get_op_result... from mix-ins. #65726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`_get_op_result_or_value` was used in mix-ins to unify the handling of op results and values. However, that function is now called in the generated constructors, such that doing so in the mix-ins is not necessary anymore.
Contributor Author
| @ftynse: Do you want to take a look at this or whom should I ask? |
ftynse approved these changes Sep 14, 2023
| super().__init__( | ||
| pdl.OperationType.get(), _get_op_result_or_value(target), loc=loc, ip=ip | ||
| ) | ||
| super().__init__(pdl.OperationType.get(), target, loc=loc, ip=ip) |
Member
There was a problem hiding this comment.
Not for this commit, but since we are in cleanup mode, can we replace all this pdl with transform.any_op?
Contributor Author
There was a problem hiding this comment.
Aha, that answers a question of mine ("whether and why we needed the PDL types"). OK, will do.
ingomueller-net deleted the python-structured-transform-get-op-result branch 
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
llvm#65726) `_get_op_result_or_value` was used in mix-ins to unify the handling of op results and values. However, that function is now called in the generated constructors, such that doing so in the mix-ins is not necessary anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
_get_op_result_or_valuewas used in mix-ins to unify the handling of op results and values. However, that function is now called in the generated constructors, such that doing so in the mix-ins is not necessary anymore.