[asan][ubsan] Enable testing with internal symbolizer #66257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| @llvm/pr-subscribers-compiler-rt-sanitizer ChangesNone -- Full diff: https://github.com//pull/66257.diff3 Files Affected:
diff --git a/compiler-rt/lib/asan/CMakeLists.txt b/compiler-rt/lib/asan/CMakeLists.txt index 1bfc6f0c5e37d84..bc5fe0be120f8d7 100644 --- a/compiler-rt/lib/asan/CMakeLists.txt +++ b/compiler-rt/lib/asan/CMakeLists.txt @@ -216,6 +216,7 @@ else() RTSanitizerCommonLibc RTSanitizerCommonCoverage RTSanitizerCommonSymbolizer + RTSanitizerCommonSymbolizerInternal RTLSanCommon RTUbsan) diff --git a/compiler-rt/lib/ubsan/CMakeLists.txt b/compiler-rt/lib/ubsan/CMakeLists.txt index 93730561523a94c..2031726afe0b59d 100644 --- a/compiler-rt/lib/ubsan/CMakeLists.txt +++ b/compiler-rt/lib/ubsan/CMakeLists.txt @@ -207,8 +207,7 @@ else() RTSanitizerCommonLibc RTSanitizerCommonCoverage RTSanitizerCommonSymbolizer - # FIXME: Some wrong with C++ demangling. - # RTSanitizerCommonSymbolizerInternal + RTSanitizerCommonSymbolizerInternal RTUbsan RTUbsan_standalone RTInterception @@ -253,8 +252,7 @@ else() RTSanitizerCommonLibc RTSanitizerCommonCoverage RTSanitizerCommonSymbolizer - # FIXME: Some wrong with C++ demangling. - # RTSanitizerCommonSymbolizerInternal + RTSanitizerCommonSymbolizerInternal RTUbsan RTUbsan_cxx RTUbsan_standalone diff --git a/compiler-rt/test/sanitizer_common/TestCases/demangle_internal.cpp b/compiler-rt/test/sanitizer_common/TestCases/demangle_internal.cpp index 3202fc17aea7d63..6ec1851275eb135 100644 --- a/compiler-rt/test/sanitizer_common/TestCases/demangle_internal.cpp +++ b/compiler-rt/test/sanitizer_common/TestCases/demangle_internal.cpp @@ -3,7 +3,7 @@ // REQUIRES: internal_symbolizer // FIXME: link internal_symbolizer. -// XFAIL: asan, hwasan, ubsan +// XFAIL: hwasan #include <algorithm> #include <assert.h> |
kstoimenov approved these changes Sep 13, 2023
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Sep 21, 2023
Local branch amd-gfx 0d570d0 Merged main:c199f7dc62f3 into amd-gfx:124b4cad343b Remote branch main 25e8105 [asan][ubsan] Enable testing with internal symbolizer (llvm#66257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.