[llvm][CMake] Expand error message shown when -fuse-ld= test fails #66778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is one of the most common issues new users face, especially as so many reccomended CMake configurations include `-DLLVM_ENABLE_LLD=ON`. I don't want the error message to get too long but let's at least say that there are 2 main reasons for the failure. If it's not those then maybe folks will find the actual problem while trying to discount them. The new message looks like: ``` CMake Error at cmake/modules/HandleLLVMOptions.cmake:330 (message): Host compiler does not support '-fuse-ld=not_a_linker'. Please make sure that 'not_a_linker' is installed and that your host compiler can compile a simple program when given the option '-fuse-ld=not_a_linker'. Call Stack (most recent call first): CMakeLists.txt:910 (include) ```
Collaborator Author
| The other way to do this is adding the information to https://llvm.org/docs/CMake.html#llvm-use-linker, but it's not as immediate. I could do both if it helps to have something to cite in answers. |
Collaborator Author
| ping! |
joker-eph approved these changes Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is one of the most common issues new users face, especially as so many reccomended CMake configurations include
-DLLVM_ENABLE_LLD=ON.I don't want the error message to get too long but let's at least say that there are 2 main reasons for the failure. If it's not those then maybe folks will find the actual problem while trying to discount them.
The new message looks like: