[mlir][python] smaller scope for vector enumgen #66992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| @llvm/pr-subscribers-mlir ChangesDon't generate enums from the main VectorOps.td file as that transitively includes enums from Arith. Full diff: https://github.com/llvm/llvm-project/pull/66992.diff 2 Files Affected:
diff --git a/mlir/python/CMakeLists.txt b/mlir/python/CMakeLists.txt index 25be18fced0f7ac..9368cb4c2f1657f 100644 --- a/mlir/python/CMakeLists.txt +++ b/mlir/python/CMakeLists.txt @@ -381,7 +381,8 @@ declare_mlir_dialect_python_bindings( TD_FILE dialects/VectorOps.td SOURCES dialects/vector.py DIALECT_NAME vector - GEN_ENUM_BINDINGS) + GEN_ENUM_BINDINGS_TD_FILE + "dialects/VectorAttributes.td") ################################################################################ # Python extensions. diff --git a/mlir/python/mlir/dialects/VectorAttributes.td b/mlir/python/mlir/dialects/VectorAttributes.td new file mode 100644 index 000000000000000..038e0ba21c3b25e --- /dev/null +++ b/mlir/python/mlir/dialects/VectorAttributes.td @@ -0,0 +1,14 @@ +//===-- VectorAttributes.td - Entry point for bindings -----*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#ifndef PYTHON_BINDINGS_VECTOR_ATTRDEFS_TD +#define PYTHON_BINDINGS_VECTOR_ATTRDEFS_TD + +include "mlir/Dialect/Vector/IR/VectorAttributes.td" + +#endif // PYTHON_BINDINGS_VECTOR_ATTRDEFS_TD |
Contributor
| Sorry, just saw this, you'll need to rebase on top of 3f30aeb in which I did the same for bazel. |
nicolasvasilache approved these changes Sep 21, 2023
Don't generate enums from the main VectorOps.td file as that transitively includes enums from Arith.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Don't generate enums from the main VectorOps.td file as that transitively includes enums from Arith.