[SPIR-V] Emit proper pointer type for OpenCL kernel arguments #67726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
michalpaszkowski requested review from Keenuts, iliya-diyachkov and sudonatalie 
Keenuts reviewed Oct 2, 2023
michalpaszkowski force-pushed the fix_kernel_arg_pointer_base_type branch from fab4250 to 4c6a208 Compare 
michalpaszkowski force-pushed the fix_kernel_arg_pointer_base_type branch from 4c6a208 to dadd40f Compare 
Member Author
| @iliya-diyachkov Do you think the change can be merged now? |
iliya-diyachkov approved these changes Oct 9, 2023
Contributor
iliya-diyachkov left a comment
iliya-diyachkov left a comment There was a problem hiding this comment.
Yes, the patch looks good to me. Thanks, Michal.
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Oct 20, 2023
Local branch amd-gfx 7e00bdd Merged main:fd1a0b0ee4d8 into amd-gfx:21aa606b362c Remote branch main 8175190 [SPIR-V] Emit proper pointer type for OpenCL kernel arguments (llvm#67726)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.