[mlir][python] Enable py312. #68009
Merged
[mlir][python] Enable py312. #68009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| @llvm/pr-subscribers-mlir ChangesPython 3.12 has been released so why not support it. Note, I'm not sure if the buildkite runners do Full diff: https://github.com/llvm/llvm-project/pull/68009.diff 1 Files Affected:
diff --git a/mlir/python/requirements.txt b/mlir/python/requirements.txt index 7671d33293f483d..631e61e1cbab1ae 100644 --- a/mlir/python/requirements.txt +++ b/mlir/python/requirements.txt @@ -1,4 +1,4 @@ -numpy>=1.19.5, <=1.23.5 +numpy>=1.19.5, <=1.26 pybind11>=2.9.0, <=2.10.3 -PyYAML>= 5.3.1, <=6.0 +PyYAML>= 5.3.1, <=6.0.1 dataclasses>=0.6, <=0.8 |
jpienaar approved these changes Oct 4, 2023
stellaraccident approved these changes Oct 4, 2023
Contributor
stellaraccident left a comment
stellaraccident left a comment There was a problem hiding this comment.
Yes. Please and thank you :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Python 3.12 has been released so why not support it. Note, I'm not sure if the buildkite runners do
check-mlir-pythonbut I tested locally (on Linux) and am currently running a broader set of tests.