[Fuchsia] Change driver build to default to off #68341
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We use this cache file for local builds too where the driver build is not a sensible default because it makes incremental links take too long. Instead lets change this option to be opt in.
Member
| @llvm/pr-subscribers-clang ChangesWe use this cache file for local builds too where the driver build is not a sensible default because it makes incremental links take too long. Instead lets change this option to be opt in. Full diff: https://github.com/llvm/llvm-project/pull/68341.diff 1 Files Affected:
diff --git a/clang/cmake/caches/Fuchsia-stage2.cmake b/clang/cmake/caches/Fuchsia-stage2.cmake index 0dcc35ee1495f55..cca53be3dc45e33 100644 --- a/clang/cmake/caches/Fuchsia-stage2.cmake +++ b/clang/cmake/caches/Fuchsia-stage2.cmake @@ -29,11 +29,7 @@ set(LLVM_USE_RELATIVE_PATHS_IN_FILES ON CACHE BOOL "") set(LLDB_ENABLE_CURSES OFF CACHE BOOL "") set(LLDB_ENABLE_LIBEDIT OFF CACHE BOOL "") -if(WIN32) - set(FUCHSIA_DISABLE_DRIVER_BUILD ON) -endif() - -if (NOT FUCHSIA_DISABLE_DRIVER_BUILD) +if (FUCHSIA_ENABLE_DRIVER_BUILD) set(LLVM_TOOL_LLVM_DRIVER_BUILD ON CACHE BOOL "") set(LLVM_DRIVER_TARGET llvm-driver) endif() |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We use this cache file for local builds too where the driver build is not a sensible default because it makes incremental links take too long. Instead lets change this option to be opt in.