[Clang][LoongArch] Support basic fp16, fp128 #68851
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
llvmbot added clang 
| ✅ With the latest revision this PR passed the C/C++ code formatter. |
xen0n reviewed Oct 12, 2023
Contributor
xen0n left a comment
xen0n left a comment There was a problem hiding this comment.
Thanks for the contribution and welcome!
As for the commit message, please take a look at the existing commits for the general feel. (For example, people typically prefix the commit title with the involved topic(s) in brackets, and use a verb phrase for the remaining.)
Besides, the LLVM side of the change lacks a test case; you can look at the other targets for reference.
| } | ||
| | ||
| setOperationAction(ISD::FP16_TO_FP, MVT::f32, Expand); | ||
| setOperationAction(ISD::FP_TO_FP16, MVT::f32, Expand); |
Contributor
There was a problem hiding this comment.
Please shrink those whitespaces; I believe that's what triggered the style checker. (After the transition away from Phabricator/Arcanist workflow, you have to set up your own auto-formatting and/or pre-commit linting hooks.)
fix whitespaces lint
[Loongarch] add test unit
Xinmudotmoe changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently, there are no officially released half-precision and quad-precision floating-point instructions for the LoongArch architecture.
This request aims to ensure that when there are projects that require this functionality, such as ROCM, PyTorch, etc., compilation, testing, and execution produce correct results instead of the current compilation errors.