Skip to content

Conversation

@egorzhdan
Copy link
Contributor

llvm-project/clang/include/clang/AST/OpenMPClause.h:7762:14: warning: parameter 'Modifier' not found in the function declaration [-Wdocumentation] /// \param Modifier The modifier applied to 'order' clause. ^~~~~~~~ llvm-project/clang/include/clang/AST/OpenMPClause.h:7762:14: note: did you mean 'M'? /// \param Modifier The modifier applied to 'order' clause. 
``` llvm-project/clang/include/clang/AST/OpenMPClause.h:7762:14: warning: parameter 'Modifier' not found in the function declaration [-Wdocumentation] /// \param Modifier The modifier applied to 'order' clause. ^~~~~~~~ llvm-project/clang/include/clang/AST/OpenMPClause.h:7762:14: note: did you mean 'M'? /// \param Modifier The modifier applied to 'order' clause. ```
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" clang:openmp OpenMP related changes to Clang labels Nov 23, 2023
@llvmbot
Copy link
Member

llvmbot commented Nov 23, 2023

@llvm/pr-subscribers-clang

Author: Egor Zhdan (egorzhdan)

Changes
llvm-project/clang/include/clang/AST/OpenMPClause.h:7762:14: warning: parameter 'Modifier' not found in the function declaration [-Wdocumentation] /// \param Modifier The modifier applied to 'order' clause. ^~~~~~~~ llvm-project/clang/include/clang/AST/OpenMPClause.h:7762:14: note: did you mean 'M'? /// \param Modifier The modifier applied to 'order' clause. 

Full diff: https://github.com/llvm/llvm-project/pull/73243.diff

1 Files Affected:

  • (modified) clang/include/clang/AST/OpenMPClause.h (+2-2)
diff --git a/clang/include/clang/AST/OpenMPClause.h b/clang/include/clang/AST/OpenMPClause.h index 549f12e87df597a..51155e63dcb8f7d 100644 --- a/clang/include/clang/AST/OpenMPClause.h +++ b/clang/include/clang/AST/OpenMPClause.h @@ -7776,10 +7776,10 @@ class OMPOrderClause final : public OMPClause { /// \param MLoc Location of the modifier OMPOrderClause(OpenMPOrderClauseKind A, SourceLocation ALoc, SourceLocation StartLoc, SourceLocation LParenLoc, - SourceLocation EndLoc, OpenMPOrderClauseModifier M, + SourceLocation EndLoc, OpenMPOrderClauseModifier Modifier, SourceLocation MLoc) : OMPClause(llvm::omp::OMPC_order, StartLoc, EndLoc), - LParenLoc(LParenLoc), Kind(A), KindKwLoc(ALoc), Modifier(M), + LParenLoc(LParenLoc), Kind(A), KindKwLoc(ALoc), Modifier(Modifier), ModifierKwLoc(MLoc) {} /// Build an empty clause. 
Copy link
Contributor

@cor3ntin cor3ntin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egorzhdan egorzhdan merged commit 18a5ca1 into llvm:main Nov 24, 2023
@egorzhdan egorzhdan deleted the wdocumentation-warning branch November 24, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:frontend Language frontend issues, e.g. anything involving "Sema" clang:openmp OpenMP related changes to Clang clang Clang issues not falling into any other category

3 participants