[SPIR-V] Mark currently failing tests as XFAIL #73858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
These tests are currently failing and their fix is being tracked in Issue llvm#60133. Marking them as XFAIL for now will get the test suite to a passing state so we can work on adding a GitHub action to automatically run these tests on a PR bot to help keep the tree green. Also removed the no-longer supported -opaque-pointers=0 flag from the couple tests where it was remaining.
Member
| @llvm/pr-subscribers-backend-spir-v Author: Natalie Chouinard (sudonatalie) ChangesThese tests are currently failing and their fix is being tracked in Issue #60133. Marking them as XFAIL for now will get the test suite to a passing state so we can work on adding a GitHub action to automatically run these tests on a PR bot to help keep the tree green. Also removed the no-longer supported -opaque-pointers=0 flag from the couple tests where it was remaining. Full diff: https://github.com/llvm/llvm-project/pull/73858.diff 11 Files Affected:
diff --git a/llvm/test/CodeGen/SPIRV/EnqueueEmptyKernel.ll b/llvm/test/CodeGen/SPIRV/EnqueueEmptyKernel.ll index 679f8ff7a0017eb..a6f172a81dc7c80 100644 --- a/llvm/test/CodeGen/SPIRV/EnqueueEmptyKernel.ll +++ b/llvm/test/CodeGen/SPIRV/EnqueueEmptyKernel.ll @@ -1,5 +1,8 @@ ; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s --check-prefix=CHECK-SPIRV +; TODO(#60133): Requires updates following opaque pointer migration. +; XFAIL: * + ;; This test checks that Invoke parameter of OpEnueueKernel instruction meet the ;; following specification requirements in case of enqueueing empty block: ;; "Invoke must be an OpFunction whose OpTypeFunction operand has: diff --git a/llvm/test/CodeGen/SPIRV/half_no_extension.ll b/llvm/test/CodeGen/SPIRV/half_no_extension.ll index a5b0ec9c92d236a..6414b62874bc71d 100644 --- a/llvm/test/CodeGen/SPIRV/half_no_extension.ll +++ b/llvm/test/CodeGen/SPIRV/half_no_extension.ll @@ -7,6 +7,9 @@ ; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s --check-prefix=CHECK-SPIRV +; TODO(#60133): Requires updates following opaque pointer migration. +; XFAIL: * + ; CHECK-SPIRV: OpCapability Float16Buffer ; CHECK-SPIRV-NOT: OpCapability Float16 diff --git a/llvm/test/CodeGen/SPIRV/linked-list.ll b/llvm/test/CodeGen/SPIRV/linked-list.ll index bce363385328d94..be7634f8a57a2af 100644 --- a/llvm/test/CodeGen/SPIRV/linked-list.ll +++ b/llvm/test/CodeGen/SPIRV/linked-list.ll @@ -1,4 +1,7 @@ -; RUN: llc -O0 -opaque-pointers=0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s +; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s + +; TODO(#60133): Requires updates following opaque pointer migration. +; XFAIL: * %struct.Node = type { %struct.Node.0 addrspace(1)* } ; CHECK: %[[#]] = OpTypeOpaque "struct.Node.0" diff --git a/llvm/test/CodeGen/SPIRV/opencl/basic/vstore_private.ll b/llvm/test/CodeGen/SPIRV/opencl/basic/vstore_private.ll index 2bc4b447c2ed196..40f1d59e4365e15 100644 --- a/llvm/test/CodeGen/SPIRV/opencl/basic/vstore_private.ll +++ b/llvm/test/CodeGen/SPIRV/opencl/basic/vstore_private.ll @@ -1,5 +1,8 @@ ; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s +; TODO(#60133): Requires updates following opaque pointer migration. +; XFAIL: * + ; CHECK: %[[#i16_ty:]] = OpTypeInt 16 0 ; CHECK: %[[#v4xi16_ty:]] = OpTypeVector %[[#i16_ty]] 4 ; CHECK: %[[#pv4xi16_ty:]] = OpTypePointer Function %[[#v4xi16_ty]] diff --git a/llvm/test/CodeGen/SPIRV/opencl/device_execution/execute_block.ll b/llvm/test/CodeGen/SPIRV/opencl/device_execution/execute_block.ll index 5b7ff169a947d2c..b001ce09f5679c7 100644 --- a/llvm/test/CodeGen/SPIRV/opencl/device_execution/execute_block.ll +++ b/llvm/test/CodeGen/SPIRV/opencl/device_execution/execute_block.ll @@ -1,5 +1,8 @@ ; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s +; TODO(#60133): Requires updates following opaque pointer migration. +; XFAIL: * + ; CHECK: %[[#bool:]] = OpTypeBool ; CHECK: %[[#true:]] = OpConstantTrue %[[#bool]] ; CHECK: OpBranchConditional %[[#true]] diff --git a/llvm/test/CodeGen/SPIRV/pstruct.ll b/llvm/test/CodeGen/SPIRV/pstruct.ll index 01b05b01e70b604..fd55e9b69e26098 100644 --- a/llvm/test/CodeGen/SPIRV/pstruct.ll +++ b/llvm/test/CodeGen/SPIRV/pstruct.ll @@ -1,4 +1,7 @@ -; RUN: llc -O0 -opaque-pointers=0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s --check-prefix=CHECK-SPIRV +; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s --check-prefix=CHECK-SPIRV + +; TODO(#60133): Requires updates following opaque pointer migration. +; XFAIL: * %struct.ST = type { i32, i32, i32 } diff --git a/llvm/test/CodeGen/SPIRV/transcoding/BuildNDRange_2.ll b/llvm/test/CodeGen/SPIRV/transcoding/BuildNDRange_2.ll index 79d360324110c53..75aa87f958d47b7 100644 --- a/llvm/test/CodeGen/SPIRV/transcoding/BuildNDRange_2.ll +++ b/llvm/test/CodeGen/SPIRV/transcoding/BuildNDRange_2.ll @@ -20,6 +20,9 @@ ; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s --check-prefix=CHECK-SPIRV +; TODO(#60133): Requires updates following opaque pointer migration. +; XFAIL: * + ; CHECK-SPIRV-DAG: %[[#LEN2_ID:]] = OpConstant %[[#]] 2 ; CHECK-SPIRV-DAG: %[[#LEN3_ID:]] = OpConstant %[[#]] 3 ; CHECK-SPIRV-DAG: %[[#ARRAY_T2:]] = OpTypeArray %[[#]] %[[#LEN2_ID]] diff --git a/llvm/test/CodeGen/SPIRV/transcoding/block_w_struct_return.ll b/llvm/test/CodeGen/SPIRV/transcoding/block_w_struct_return.ll index 52b25a5913f09c0..5ecd7f73a52e372 100644 --- a/llvm/test/CodeGen/SPIRV/transcoding/block_w_struct_return.ll +++ b/llvm/test/CodeGen/SPIRV/transcoding/block_w_struct_return.ll @@ -1,5 +1,8 @@ ; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s --check-prefixes=CHECK-SPIRV,CHECK-SPIRV1_4 +; TODO(#60133): Requires updates following opaque pointer migration. +; XFAIL: * + ;; TODO: We cannot check SPIR_V 1.1 and 1.4 simultaneously, implement additional ;; run with CHECK-SPIRV1_1. diff --git a/llvm/test/CodeGen/SPIRV/transcoding/enqueue_kernel.ll b/llvm/test/CodeGen/SPIRV/transcoding/enqueue_kernel.ll index 6de03dd1651879e..cf124ec0a2782e5 100644 --- a/llvm/test/CodeGen/SPIRV/transcoding/enqueue_kernel.ll +++ b/llvm/test/CodeGen/SPIRV/transcoding/enqueue_kernel.ll @@ -1,5 +1,8 @@ ; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s --check-prefix=CHECK-SPIRV +; TODO(#60133): Requires updates following opaque pointer migration. +; XFAIL: * + ; CHECK-SPIRV: OpEntryPoint Kernel %[[#BlockKer1:]] "__device_side_enqueue_block_invoke_kernel" ; CHECK-SPIRV: OpEntryPoint Kernel %[[#BlockKer2:]] "__device_side_enqueue_block_invoke_2_kernel" ; CHECK-SPIRV: OpEntryPoint Kernel %[[#BlockKer3:]] "__device_side_enqueue_block_invoke_3_kernel" diff --git a/llvm/test/CodeGen/SPIRV/transcoding/extract_insert_value.ll b/llvm/test/CodeGen/SPIRV/transcoding/extract_insert_value.ll index e0392d05cc30677..fd29bc8a1ebf89d 100644 --- a/llvm/test/CodeGen/SPIRV/transcoding/extract_insert_value.ll +++ b/llvm/test/CodeGen/SPIRV/transcoding/extract_insert_value.ll @@ -1,4 +1,7 @@ -; RUN: llc -O0 -opaque-pointers=0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s --check-prefix=CHECK-SPIRV +; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s --check-prefix=CHECK-SPIRV + +; TODO(#60133): Requires updates following opaque pointer migration. +; XFAIL: * ;; Check 'LLVM ==> SPIR-V' conversion of extractvalue/insertvalue. diff --git a/llvm/test/CodeGen/SPIRV/transcoding/global_block.ll b/llvm/test/CodeGen/SPIRV/transcoding/global_block.ll index 96b275956178cce..2f44e1943b6a6da 100644 --- a/llvm/test/CodeGen/SPIRV/transcoding/global_block.ll +++ b/llvm/test/CodeGen/SPIRV/transcoding/global_block.ll @@ -1,5 +1,8 @@ ; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s --check-prefixes=CHECK-SPIRV,CHECK-SPIRV1_4 +; TODO(#60133): Requires updates following opaque pointer migration. +; XFAIL: * + ;; There are no blocks in SPIR-V. Therefore they are translated into regular ;; functions. An LLVM module which uses blocks, also contains some auxiliary ;; block-specific instructions, which are redundant in SPIR-V and should be |
michalpaszkowski approved these changes Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These tests are currently failing and their fix is being tracked in Issue #60133. Marking them as XFAIL for now will get the test suite to a passing state so we can work on adding a GitHub action to automatically run these tests on a PR bot to help keep the tree green.
Also removed the no-longer supported -opaque-pointers=0 flag from the couple tests where it was remaining.