[clangd] Initialize HighlightingsBuilder::Resolver

[HighCommander4]

No description provided.

[llvmbot]

@llvm/pr-subscribers-clangd

Author: Nathan Ridge (HighCommander4)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/74971.diff

1 Files Affected:

• (modified) clang-tools-extra/clangd/SemanticHighlighting.cpp (+2-1)

diff --git a/clang-tools-extra/clangd/SemanticHighlighting.cpp b/clang-tools-extra/clangd/SemanticHighlighting.cpp index 49e479abf45621..abc3d1f58a776e 100644 --- a/clang-tools-extra/clangd/SemanticHighlighting.cpp +++ b/clang-tools-extra/clangd/SemanticHighlighting.cpp @@ -418,7 +418,8 @@ class HighlightingsBuilder { public: HighlightingsBuilder(const ParsedAST &AST, const HighlightingFilter &Filter) : TB(AST.getTokens()), SourceMgr(AST.getSourceManager()), - LangOpts(AST.getLangOpts()), Filter(Filter) {} + LangOpts(AST.getLangOpts()), Filter(Filter), + Resolver(AST.getHeuristicResolver()) {} HighlightingToken &addToken(SourceLocation Loc, HighlightingKind Kind) { auto Range = getRangeForSourceLocation(Loc); 

[HighCommander4]

Fixing issue spotted in #71279 (comment).

I tried to construct a testcase that the previous code would fail but couldn't: kindForDecl only does something interesting with the resolver for UnresolvedUsingValueDecl, but the call sites in HighlightingsBuilder only use kindForType, which only calls into kindForDecl in the case of a TemplateTypeParmType or TagType, and I don't think those can ever have an UnresolvedUsingValueDecl as their associated decl.

[zyn0217]

Thank you! LGTM modulo one nit: could you please remove the nullptr member initializer for Resolver? That looks unnecessary now.