[libc] fix more -Wmissing-brace #77382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Similar to llvm#77345, the buildbots are observing similar warnings for the sse2 implementation. llvm-project/libc/src/__support/HashTable/sse2/bitmask_impl.inc:36:13: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] return {bitmask}; ^~~~~~~ { } llvm-project/libc/src/__support/HashTable/sse2/bitmask_impl.inc:45:13: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] return {static_cast<uint16_t>(~mask_available().word)}; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ { } Link: https://lab.llvm.org/buildbot/#/builders/163/builds/49350/steps/8/logs/stdio Link: llvm#74506
Member
| @llvm/pr-subscribers-libc Author: Nick Desaulniers (nickdesaulniers) ChangesSimilar to #77345, the buildbots are observing similar warnings for the sse2 Link: https://lab.llvm.org/buildbot/#/builders/163/builds/49350/steps/8/logs/stdio Full diff: https://github.com/llvm/llvm-project/pull/77382.diff 1 Files Affected:
diff --git a/libc/src/__support/HashTable/sse2/bitmask_impl.inc b/libc/src/__support/HashTable/sse2/bitmask_impl.inc index d65240901ed406..e778c19f284a8a 100644 --- a/libc/src/__support/HashTable/sse2/bitmask_impl.inc +++ b/libc/src/__support/HashTable/sse2/bitmask_impl.inc @@ -33,7 +33,7 @@ struct Group { LIBC_INLINE IteratableBitMask match_byte(uint8_t byte) const { auto cmp = _mm_cmpeq_epi8(data, _mm_set1_epi8(byte)); auto bitmask = static_cast<uint16_t>(_mm_movemask_epi8(cmp)); - return {bitmask}; + return {{bitmask}}; } LIBC_INLINE BitMask mask_available() const { @@ -42,7 +42,7 @@ struct Group { } LIBC_INLINE IteratableBitMask occupied() const { - return {static_cast<uint16_t>(~mask_available().word)}; + return {{static_cast<uint16_t>(~mask_available().word)}}; } }; } // namespace internal |
lntue approved these changes Jan 8, 2024
justinfargnoli pushed a commit to justinfargnoli/llvm-project that referenced this pull request Jan 28, 2024
Similar to llvm#77345, the buildbots are observing similar warnings for the sse2 implementation. llvm-project/libc/src/__support/HashTable/sse2/bitmask_impl.inc:36:13: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] return {bitmask}; ^~~~~~~ { } llvm-project/libc/src/__support/HashTable/sse2/bitmask_impl.inc:45:13: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] return {static_cast<uint16_t>(~mask_available().word)}; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ { } Link: https://lab.llvm.org/buildbot/#/builders/163/builds/49350/steps/8/logs/stdio Link: llvm#74506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Similar to #77345, the buildbots are observing similar warnings for the sse2
implementation.
Link: https://lab.llvm.org/buildbot/#/builders/163/builds/49350/steps/8/logs/stdio
Link: #74506