[OpenMP] Fix libomp debug build. #81029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Disable libstdc++ assertions in the runtime library just like in https://reviews.llvm.org/D143168.
dfukalov added cmake 
Member
| @llvm/pr-subscribers-openmp Author: Daniil Fukalov (dfukalov) ChangesDisable libstdc++ assertions in the runtime library just like in https://reviews.llvm.org/D143168. Full diff: https://github.com/llvm/llvm-project/pull/81029.diff 1 Files Affected:
diff --git a/openmp/runtime/src/CMakeLists.txt b/openmp/runtime/src/CMakeLists.txt index b0ecf1213dabe5..ff129feb5b6fa0 100644 --- a/openmp/runtime/src/CMakeLists.txt +++ b/openmp/runtime/src/CMakeLists.txt @@ -152,6 +152,10 @@ if(UNIX) set(LIBOMP_DL_LIBS ${CMAKE_DL_LIBS}) endif() +# Disable libstdc++ assertions, even in an LLVM_ENABLE_ASSERTIONS build, to +# avoid an unwanted dependency on libstdc++.so. +add_definitions(-U_GLIBCXX_ASSERTIONS) + # Add the OpenMP library libomp_get_ldflags(LIBOMP_CONFIGURED_LDFLAGS) |
|
|
jhuber6 approved these changes Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Disable libstdc++ assertions in the runtime library just like in https://reviews.llvm.org/D143168.