Skip to content

Conversation

@steakhal
Copy link
Contributor

In fact, the cleanup attribute is only added to the CFG, but still unhandled by CSA.
I propose dropping this false "support" statement from the docs.

In fact, the cleanup attribute is only added to the CFG, but still unhandled by CSA. I propose dropping this false "support" statement from the docs.
@steakhal steakhal added this to the LLVM 18.X Release milestone Feb 15, 2024
@steakhal steakhal requested a review from Xazax-hun February 15, 2024 08:38
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Feb 15, 2024
@llvmbot
Copy link
Member

llvmbot commented Feb 15, 2024

@llvm/pr-subscribers-clang-static-analyzer-1

@llvm/pr-subscribers-clang

Author: Balazs Benics (steakhal)

Changes

In fact, the cleanup attribute is only added to the CFG, but still unhandled by CSA.
I propose dropping this false "support" statement from the docs.


Full diff: https://github.com/llvm/llvm-project/pull/81834.diff

1 Files Affected:

  • (modified) clang/docs/ReleaseNotes.rst (-3)
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst index 95d44951ae7ee6..b4cbe18aa150a9 100644 --- a/clang/docs/ReleaseNotes.rst +++ b/clang/docs/ReleaseNotes.rst @@ -1343,9 +1343,6 @@ New features of static analysis tools, such as the Clang Static Analyzer. `Documentation <https://clang.llvm.org/docs/AttributeReference.html#suppress>`__. -- Added support for the ``cleanup`` attribute. - `Documentation <https://clang.llvm.org/docs/AttributeReference.html#cleanup>`__. - - Support "Deducing this" (P0847R7). (Worked out of the box) (`af4751738db8 <https://github.com/llvm/llvm-project/commit/af4751738db89a142a8880c782d12d4201b222a8>`__) 
@tstellar tstellar merged commit c90f200 into llvm:release/18.x Feb 16, 2024
@pointhex pointhex mentioned this pull request May 7, 2024
@steakhal steakhal deleted the csa-admit-not-supporting-cleanup-attrs branch December 15, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:static analyzer clang Clang issues not falling into any other category release:backport

4 participants