[mlir] Update comment about propertiesAttr (NFC) #89633
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Adds an option to `mlir-tblgen -gen-op-defs` `op-shard-count=N` that divides the op class definitions and op list into N segments, e.g. ``` // mlir-tblgen -gen-op-defs -op-shard-count=2 void FooDialect::initialize() { addOperations< >(); addOperations< >(); } ``` When split across multiple source files, this can help significantly improve dialect compile time for dialects with a large opset. stack-info: PR: #89423, branch: users/mogball/pr_1 This PR massively reorganizes the Test dialect's source files. It moves manually-written op hooks into `TestOpDefs.cpp`, moves format custom directive parsers and printers into `TestFormatUtils`, adds missing comment blocks, and moves around where generated source files are included for types, attributes, enums, etc. into their own source file. This will hopefully help navigate the test dialect source code, but also speeds up compile time of the test dialect by putting generated source files into separate compilation units. This also sets up the test dialect to shard its op definitions, done in the next PR. stack-info: PR: #89424, branch: users/mogball/pr_2
This PR uses the new op sharding mechanism in tablegen to shard the test dialect's op definitions. This breaks the definition of ops into multiple source files, speeding up compile time of the test dialect dramatically. This improves developer cycle times when iterating on the test dialect. stack-info: PR: #89628, branch: users/Mogball/stack/1
Member
| @llvm/pr-subscribers-mlir-affine @llvm/pr-subscribers-mlir-core Author: Jeff Niu (Mogball) Changes[mlir] Update comment about The comment is misleading because Full diff: https://github.com/llvm/llvm-project/pull/89633.diff 1 Files Affected:
diff --git a/mlir/include/mlir/IR/OperationSupport.h b/mlir/include/mlir/IR/OperationSupport.h index 2c1c490aac49b8..2c6e8253b4327a 100644 --- a/mlir/include/mlir/IR/OperationSupport.h +++ b/mlir/include/mlir/IR/OperationSupport.h @@ -960,9 +960,12 @@ struct OperationState { /// Regions that the op will hold. SmallVector<std::unique_ptr<Region>, 1> regions; - // If we're creating an unregistered operation, this Attribute is used to - // build the properties. Otherwise it is ignored. For registered operations - // see the `getOrAddProperties` method. + // This Attribute is used to opaquely construct the properties of the + // operation. If we're creating an unregistered operation, the Attribute is + // used as-is as the Properties storage of the operation. Otherwise, the + // operation properties are constructed opaquely using its + // `setPropertiesFromAttr` hook. Note that `getOrAddProperties` is the + // preferred method to construct properties from C++. Attribute propertiesAttr; private: |
Mogball force-pushed the users/Mogball/stack/1 branch from 1c47645 to 478b4e8 Compare 
llvmbot added mlir:affine bazel Mogball force-pushed the users/Mogball/stack/1 branch from b0871b7 to 478b4e8 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
[mlir] Update comment about
propertiesAttr(NFC)The comment is misleading because
propertiesAttris not actuallyignored when the operation isn't unregistered.