Skip to content

Commit 8c744bd

Browse files
committed
add vertical line feature and rename previous methods
1 parent deaa53f commit 8c744bd

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/main/java/edu/thoughtworks/training/Asterisk.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,19 @@ public class Asterisk {
44

55
private static final String ASTERISK = "*";
66

7-
public String print() {
7+
public String printAnAsterisk() {
88
return ASTERISK;
99
}
1010

11-
public String print(int n) {
11+
public String printHorizontalLine(int n) {
1212
StringBuilder builder = new StringBuilder();
13-
for (int i=0; i<n; ++i) builder.append(print());
13+
for (int i = 0; i < n; ++i) builder.append(printAnAsterisk());
1414
return builder.toString();
1515
}
1616

1717
public String printVerticalLine(int n) {
18-
return null;
18+
StringBuilder builder = new StringBuilder();
19+
for (int i = 0; i < n; ++i) builder.append(printAnAsterisk()).append("\n");
20+
return builder.toString();
1921
}
2022
}

src/test/java/edu/thoughtworks/training/AsteriskShould.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@ public class AsteriskShould {
88
@Test
99
public void printAnAsterisk() {
1010
Asterisk asterisk = new Asterisk();
11-
assertEquals("Asterisk is not returning an asterisk", "*", asterisk.print());
11+
assertEquals("Asterisk is not returning an asterisk", "*", asterisk.printAnAsterisk());
1212
}
1313

1414
@Test
1515
public void printANumberOfAsterisk() {
1616
Asterisk asterisk = new Asterisk();
1717
int n = 6;
18-
assertEquals("Asterisk prints less than two asterisks", "******", asterisk.print(n));
18+
assertEquals("Asterisk prints less than two asterisks", "******", asterisk.printHorizontalLine(n));
1919
}
2020

2121
@Test

0 commit comments

Comments
 (0)