[llvm] Replace uses of Type::getPointerTo (NFC)

opaque pointer clean-up effort (NFC)

Author: JOE1994

llvm/lib/ExecutionEngine/Orc/Speculation.cpp

@@ -67,7 +67,7 @@ void IRSpeculationLayer::emit(std::unique_ptr<MaterializationResponsibility> R,
  auto SpeculatorVTy = StructType::create(MContext, "Class.Speculator");
  auto RuntimeCallTy = FunctionType::get(
  Type::getVoidTy(MContext),
- {SpeculatorVTy->getPointerTo(), Type::getInt64Ty(MContext)}, false);
+ {PointerType::getUnqual(MContext), Type::getInt64Ty(MContext)}, false);
  auto RuntimeCall =
  Function::Create(RuntimeCallTy, Function::LinkageTypes::ExternalLinkage,
  "__orc_speculate_for", &M);

llvm/lib/IR/Constants.cpp

@@ -2367,7 +2367,7 @@ Constant *ConstantExpr::getAlignOf(Type* Ty) {
  // alignof is implemented as: (i64) gep ({i1,Ty}*)null, 0, 1
  // Note that a non-inbounds gep is used, as null isn't within any object.
  Type *AligningTy = StructType::get(Type::getInt1Ty(Ty->getContext()), Ty);
- Constant *NullPtr = Constant::getNullValue(AligningTy->getPointerTo(0));
+ Constant *NullPtr = Constant::getNullValue(PointerType::getUnqual(AligningTy->getContext()));
  Constant *Zero = ConstantInt::get(Type::getInt64Ty(Ty->getContext()), 0);
  Constant *One = ConstantInt::get(Type::getInt32Ty(Ty->getContext()), 1);
  Constant *Indices[2] = { Zero, One };

llvm/lib/Transforms/Coroutines/CoroFrame.cpp

@@ -1292,10 +1292,7 @@ static StructType *buildFrameType(Function &F, coro::Shape &Shape,
  std::optional<FieldIDType> SwitchIndexFieldId;
 
  if (Shape.ABI == coro::ABI::Switch) {
- auto *FramePtrTy = FrameTy->getPointerTo();
- auto *FnTy = FunctionType::get(Type::getVoidTy(C), FramePtrTy,
- /*IsVarArg=*/false);
- auto *FnPtrTy = FnTy->getPointerTo();
+ auto *FnPtrTy = PointerType::getUnqual(C);
 
  // Add header fields for the resume and destroy functions.
  // We can rely on these being perfectly packed.
@@ -2487,7 +2484,7 @@ static Value *emitGetSwiftErrorValue(IRBuilder<> &Builder, Type *ValueTy,
  coro::Shape &Shape) {
  // Make a fake function pointer as a sort of intrinsic.
  auto FnTy = FunctionType::get(ValueTy, {}, false);
- auto Fn = ConstantPointerNull::get(FnTy->getPointerTo());
+ auto Fn = ConstantPointerNull::get(Builder.getPtrTy());
 
  auto Call = Builder.CreateCall(FnTy, Fn, {});
  Shape.SwiftErrorOps.push_back(Call);
@@ -2501,9 +2498,9 @@ static Value *emitGetSwiftErrorValue(IRBuilder<> &Builder, Type *ValueTy,
 static Value *emitSetSwiftErrorValue(IRBuilder<> &Builder, Value *V,
  coro::Shape &Shape) {
  // Make a fake function pointer as a sort of intrinsic.
- auto FnTy = FunctionType::get(V->getType()->getPointerTo(),
+ auto FnTy = FunctionType::get(Builder.getPtrTy(),
  {V->getType()}, false);
- auto Fn = ConstantPointerNull::get(FnTy->getPointerTo());
+ auto Fn = ConstantPointerNull::get(Builder.getPtrTy());
 
  auto Call = Builder.CreateCall(FnTy, Fn, { V });
  Shape.SwiftErrorOps.push_back(Call);

llvm/unittests/Analysis/ScalarEvolutionTest.cpp

@@ -352,7 +352,7 @@ TEST_F(ScalarEvolutionsTest, CompareSCEVComplexity) {
 
 TEST_F(ScalarEvolutionsTest, CompareValueComplexity) {
  IntegerType *IntPtrTy = M.getDataLayout().getIntPtrType(Context);
- PointerType *IntPtrPtrTy = IntPtrTy->getPointerTo();
+ PointerType *IntPtrPtrTy = PointerType::getUnqual(Context);
 
  FunctionType *FTy =
  FunctionType::get(Type::getVoidTy(Context), {IntPtrTy, IntPtrTy}, false);

llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp

@@ -3070,8 +3070,8 @@ TEST_F(OpenMPIRBuilderTest, CopyinBlocks) {
  OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP(), DL});
 
  IntegerType *Int32 = Type::getInt32Ty(M->getContext());
- AllocaInst *MasterAddress = Builder.CreateAlloca(Int32->getPointerTo());
- AllocaInst *PrivAddress = Builder.CreateAlloca(Int32->getPointerTo());
+ AllocaInst *MasterAddress = Builder.CreateAlloca(Builder.getPtrTy());
+ AllocaInst *PrivAddress = Builder.CreateAlloca(Builder.getPtrTy());
 
  BasicBlock *EntryBB = BB;
 

llvm/unittests/IR/AsmWriterTest.cpp

@@ -87,7 +87,7 @@ TEST(AsmWriterTest, PrintNullOperandBundle) {
  LLVMContext C;
  Type *Int32Ty = Type::getInt32Ty(C);
  FunctionType *FnTy = FunctionType::get(Int32Ty, Int32Ty, /*isVarArg=*/false);
- Value *Callee = Constant::getNullValue(FnTy->getPointerTo());
+ Value *Callee = Constant::getNullValue(PointerType::getUnqual(C));
  Value *Args[] = {ConstantInt::get(Int32Ty, 42)};
  std::unique_ptr<BasicBlock> NormalDest(BasicBlock::Create(C));
  std::unique_ptr<BasicBlock> UnwindDest(BasicBlock::Create(C));

llvm/unittests/IR/IRBuilderTest.cpp

@@ -190,7 +190,7 @@ TEST_F(IRBuilderTest, IntrinsicsWithScalableVectors) {
  // LLVMScalarOrSameVectorWidth.
 
  Type *VecTy = VectorType::get(Builder.getInt32Ty(), 4, true);
- Type *PtrToVecTy = VecTy->getPointerTo();
+ Type *PtrToVecTy = Builder.getPtrTy();
  PredTy = VectorType::get(Builder.getInt1Ty(), 4, true);
 
  ArgTys.clear();