Fix incorrect usage of package.json types/main in package subdirectories

[andrewbranch]

Fixes a bug I noticed randomly

The content of moduleResolution_packageJson_yesAtPackageRoot.ts, for easier reviewing:

// @noImplicitReferences: true // @traceResolution: true // @Filename: /node_modules/foo/bar/index.js not read // @Filename: /node_modules/foo/package.json { "name": "foo", "version": "1.2.3", "types": "types.d.ts" } // @Filename: /node_modules/foo/types.d.ts export const x = 0; // @Filename: /a.ts import { x } from "foo/bar";

You can see the resolution of "foo/bar" incorrectly looking for /node_modules/foo/bar/types.d.ts due to package.json content in /node_modules/foo. (It doesn’t change the final resolution in these tests because /node_modules/foo/bar/types.d.ts doesn’t exist.) Presumably this problem only escaped detection for ~10 years because whatever value was in package.json "types" usually is either "index.d.ts", which would get looked up in subdirectories anyway, or is a path that doesn’t exist when resolved relative to the subdirectory path.

[andrewbranch]

@typescript-bot test top400

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
test top400	✅ Started

[andrewbranch]

@typescript-bot test top400

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
test top400	✅ Started	✅ Results

[typescript-bot]

@andrewbranch Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60696/merge:

Everything looks good!