Skip to content
This repository was archived by the owner on Nov 30, 2023. It is now read-only.

Commit 0762884

Browse files
committed
Fixes
1 parent 095cdae commit 0762884

File tree

11 files changed

+14
-43
lines changed

11 files changed

+14
-43
lines changed

container-templates/docker-compose/dev-container.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
# **************************************************************************
1010

1111
# Debian and Ubuntu based images are supported. Alpine images are not yet supported.
12-
FROM ubuntu:1804
12+
FROM ubuntu:18.04
1313

1414
# Install common tools developers typically will need like git
1515
RUN apt-get update \

container-templates/dockerfile/dev-container.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#-----------------------------------------------------------------------------------------
55

66
# Debian and Ubuntu based images are supported. Alpine images are not yet supported.
7-
FROM ubuntu:1804
7+
FROM ubuntu:18.04
88

99
# Install common tools developers typically will need
1010
RUN apt-get update \

container-templates/image/.vscode/devContainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "Dev Container Definition Template - Container Image",
3-
"image": "ubuntu:1804",
3+
"image": "ubuntu:18.04",
44
"appPort": 3000,
55
"extensions": [
66
"mutantdino.resourcemonitor"

containers/azure-cli/dev-container.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Licensed under the MIT License. See LICENSE in the project root for license information.
44
#-----------------------------------------------------------------------------------------
55

6-
FROM debian
6+
FROM debian:9
77

88
# Install git
99
RUN apt-get update && apt-get -y install git

containers/azure-terraform/dev-container.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#-----------------------------------------------------------------------------------------
55

66
# Pick any base image, but if you select node, skip installing node. 😊
7-
FROM ubuntu:1804
7+
FROM ubuntu:18.04
88

99
# Install required tools
1010
RUN apt-get update \

containers/cpp/dev-container.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Licensed under the MIT License. See LICENSE in the project root for license information.
44
#-----------------------------------------------------------------------------------------
55

6-
FROM ubuntu:1804
6+
FROM ubuntu:18.04
77

88
# Install git
99
RUN apt-get update && apt-get -y install git

containers/docker-in-docker-compose/dev-container.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#-----------------------------------------------------------------------------------------
55

66
# Note: You can use any Debian/Ubuntu based image you want.
7-
FROM ubuntu:1804
7+
FROM ubuntu:18.04
88

99
# Install git
1010
RUN apt-get update \

containers/docker-in-docker/dev-container.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#-----------------------------------------------------------------------------------------
66

77
# Note: You can use any Debian/Ubuntu based image you want.
8-
FROM ubuntu:1804
8+
FROM ubuntu:18.04
99

1010
# Install git
1111
RUN apt-get update \

containers/kubernetes-helm/.vscode/devContainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@
77
],
88
"runArgs": ["-e", "SYNC_LOCALHOST_KUBECONFIG=true",
99
"-v", "/var/run/docker.sock:/var/run/docker.sock",
10-
"-v", "$HOME/.kube:/root/.kube-localhost"]
10+
"-v", "${env:HOME}${env:USERPROFILE}/.kube:/root/.kube-localhost"]
1111
}

containers/kubernetes-helm/README.md

Lines changed: 4 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -30,28 +30,9 @@ To get started, follow the appropriate steps below for your operating system.
3030

3131
3. Check **Kubernetes > Enable Kubernetes**
3232

33-
4. Open this folder in VS Code
33+
4. Run the **Remote: Open Folder in Container...** command and select a local copy of this folder
3434

35-
5. Edit `.vscode/devConatiner.json` and change `$HOME` in the last item in the `runArgs` array to the absolute path of your home / user profile folder. e.g. On macOS:
36-
37-
```json
38-
"runArgs": ["-e", "SYNC_LOCALHOST_KUBECONFIG=true",
39-
"-v", "/var/run/docker.sock:/var/run/docker.sock",
40-
"-v", "/Users/clantz/.kube:/root/.kube-localhost"]
41-
```
42-
On Windows:
43-
44-
```json
45-
"runArgs": ["-e", "SYNC_LOCALHOST_KUBECONFIG=true",
46-
"-v", "/var/run/docker.sock:/var/run/docker.sock",
47-
"-v", "C:\\Users\\clantz\\.kube:/root/.kube-localhost"]
48-
```
49-
50-
> **Note:** Resolving [vscode-remote#670](https://github.com/Microsoft/vscode-remote/issues/670) and [vscode-remote#669](https://github.com/Microsoft/vscode-remote/issues/669) will remove this step.
51-
52-
6. Run the **Remote: Reopen folder in Container** command. Once connected, you should see your clusters in the Kubernetes explorer.
53-
54-
7. [Optional] If you want to use [Helm](https://helm.sh), open a VS Code terminal and run:
35+
5. [Optional] If you want to use [Helm](https://helm.sh), open a VS Code terminal and run:
5536
```
5637
helm init
5738
```
@@ -66,19 +47,9 @@ To get started, follow the appropriate steps below for your operating system.
6647
kubectl config set-context minikube
6748
```
6849
69-
3. Open this folder in VS Code
70-
71-
4. Edit `.vscode/devConatiner.json` and change `$HOME` in the last item in the `runArgs` array to the absolute path of your home folder. e.g.
72-
```json
73-
"runArgs": ["-e", "SYNC_LOCALHOST_KUBECONFIG=true",
74-
"-v","/var/run/docker.sock:/var/run/docker.sock",
75-
"-v", "/home/clantz/.kube:/root/.kube-localhost"]
76-
```
77-
> **Note:** Resolving [vscode-remote#670](https://github.com/Microsoft/vscode-remote/issues/670) will remove this step.
78-
79-
5. Run the **Remote: Reopen folder in Container** command. Once connected, you should see your clusters in the Kubernetes explorer.
50+
3. Run the **Remote: Open Folder in Container...** command and select a local copy of this folder
8051
81-
6. [Optional] If you want to use [Helm](https://helm.sh), open a VS Code terminal and run:
52+
4. [Optional] If you want to use [Helm](https://helm.sh), open a VS Code terminal and run:
8253
```
8354
helm init
8455
```

0 commit comments

Comments
 (0)