feat(NODE-6882): close outstanding connections #4499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nbbeeken force-pushed the NODE-6882-close-inuse branch 5 times, most recently from 3b95935 to 4b798d7 Compare nbbeeken force-pushed the NODE-6882-close-inuse branch 2 times, most recently from 0d71ec5 to 008c6dc Compare nbbeeken force-pushed the NODE-6882-close-inuse branch from 008c6dc to 67421a1 Compare 
nbbeeken commented Apr 24, 2025
nbbeeken commented Apr 24, 2025
nbbeeken commented Apr 24, 2025
nbbeeken commented Apr 24, 2025
nbbeeken commented Apr 24, 2025
nbbeeken commented Apr 24, 2025
baileympearson added the Primary Review 
baileympearson requested changes Apr 25, 2025
nbbeeken force-pushed the NODE-6882-close-inuse branch 6 times, most recently from 3159584 to 99d6a90 Compare baileympearson requested changes Apr 29, 2025
nbbeeken force-pushed the NODE-6882-close-inuse branch from 233531a to 91a3103 Compare test/integration/connection-monitoring-and-pooling/connection_pool.test.ts Outdated Show resolved Hide resolved
nbbeeken force-pushed the NODE-6882-close-inuse branch from d9ccf0b to ff8e814 Compare baileympearson requested changes May 1, 2025
baileympearson requested changes May 1, 2025
nbbeeken force-pushed the NODE-6882-close-inuse branch 4 times, most recently from cb5bd62 to 4c11661 Compare 
nbbeeken force-pushed the NODE-6882-close-inuse branch from 4c11661 to a46ca1d Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
Yes
What is the motivation for this change?
Graceful event loop exit
Release Highlight
MongoClient close shuts outstanding in-use connections
The
MongoClient.close()method now shuts connections that are in-use allowing the event loop to close if the only remaining resource was the MongoClient.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript