- Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(NODE-4179): allow secureContext in KMS TLS options #4578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
durran commented Jul 8, 2025
test/integration/client-side-encryption/client_side_encryption.prose.test.ts Show resolved Hide resolved
durran commented Jul 8, 2025
durran commented Jul 8, 2025
75cb045 to 68309a1 Compare dariakp reviewed Jul 9, 2025
dariakp requested changes Jul 9, 2025
addaleax reviewed Jul 10, 2025
dariakp requested changes Jul 11, 2025
dariakp requested changes Jul 17, 2025
dariakp requested changes Jul 22, 2025
dariakp approved these changes Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Allows users to pass a
secureContextoption to the TLS options in client encryption and auto encryption.What is changing?
secureContextoption to thetlsOptions:<provider>option inautoEncryptionoptions on theMongoClientor the options forClientEncryption.secureContextoption takes precedence over the driver tls* options, that the tls* options aren't attempted to be read from the file, and that it works end-to-end.Is there new documentation needed for these changes?
Yes, update the MongoDB manual to show the precedence of the options.
What is the motivation for this change?
NODE-4179
Release Highlight
Allow a
secureContextfor Auto Encryption and Client Encryption TLS optionsThis can be provided in the
tlsOptionsoption both both objects.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript