feat(NODE-6472): findOne and find no longer keep open cursors #4580
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Changes
findOneto set options that will not require a cursor or a killCursors command. Updatesfindto not leave cursors open on the server when batch size and limit are equal.What is changing?
batchSizetobatchSize + 1when the limit is equal to it.Is there new documentation needed for these changes?
API docs on the findOne options.
What is the motivation for this change?
NODE-6472
Release Highlight
collection.findOne()andcollection.find()will no longer potentially leave open cursors on the serverThe
findOnecommand will now always set thelimitoption to1andsingleBatchtotrue. Thelimit,noCursorResponseandbatchSizeoptions have also been deprecated, and the command will guarantee no more cursors can be orphaned and nokillCursorscommand will be potentially executed.findwill now setlimittobatchSize + 1when both options were equal, to avoid leaving cursors open.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript