Bug 2011449 - Part 1: Make it so that newtab messages don't reappear on next load when dismissed. r=home-newtab-reviewers,nbarrett

This was due to a bug in how "data: false" was being interpreted (a false value for `data` on an action causes it to not actually be dispatched via the Redux store!) Differential Revision: https://phabricator.services.mozilla.com/D280828

Author: mikeconley

browser/extensions/newtab/common/Reducers.sys.mjs

@@ -596,7 +596,7 @@ function Messages(prevState = INITIAL_STATE.Messages, action) {
  portID: action.data.portID || "",
  };
  case at.MESSAGE_TOGGLE_VISIBILITY:
- return { ...prevState, isVisible: action.data };
+ return { ...prevState, isVisible: action.data.isVisible };
  default:
  return prevState;
  }

browser/extensions/newtab/data/content/activity-stream.bundle.js

@@ -6944,7 +6944,7 @@ function Messages(prevState = INITIAL_STATE.Messages, action) {
  portID: action.data.portID || "",
  };
  case actionTypes.MESSAGE_TOGGLE_VISIBILITY:
- return { ...prevState, isVisible: action.data };
+ return { ...prevState, isVisible: action.data.isVisible };
  default:
  return prevState;
  }

browser/extensions/newtab/lib/NewTabMessaging.sys.mjs

@@ -80,7 +80,9 @@ export class NewTabMessaging {
  this.store.dispatch(
  ac.AlsoToPreloaded({
  type: at.MESSAGE_TOGGLE_VISIBILITY,
- data: true,
+ data: {
+ isVisible: true,
+ },
  })
  );
  }
@@ -159,6 +161,14 @@ export class NewTabMessaging {
  break;
  case at.MESSAGE_DISMISS:
  this.sendTelemetry("DISMISS", action.data.message);
+ this.store.dispatch(
+ ac.AlsoToPreloaded({
+ type: at.MESSAGE_TOGGLE_VISIBILITY,
+ data: {
+ isVisible: false,
+ },
+ })
+ );
  break;
  case at.MESSAGE_CLICK:
  this.sendTelemetry("CLICK", action.data.message, action.data.source);