Display all decompilers in list even if unavailable

Author: niranjan94

app/src/main/kotlin/com/njlabs/showjava/activities/decompiler/DecompilerActivity.kt

@@ -32,6 +32,7 @@ import android.text.style.StyleSpan
 import android.view.LayoutInflater
 import android.view.View
 import android.widget.Toast
+import androidx.appcompat.app.AlertDialog
 import com.google.firebase.analytics.FirebaseAnalytics
 import com.njlabs.showjava.Constants
 import com.njlabs.showjava.R
@@ -91,9 +92,6 @@ class DecompilerActivity : BaseActivity() {
  val decompilerDescriptions = resources.getStringArray(R.array.decompilerDescriptions)
 
  decompilersValues.forEachIndexed { index, decompiler ->
- if (!isAvailable(decompiler)) {
- return@forEachIndexed
- }
  val view = LayoutInflater.from(pickerList.context)
  .inflate(R.layout.layout_pick_decompiler_list_item, pickerList, false)
  view.decompilerName.text = decompilers[index]
@@ -184,6 +182,16 @@ class DecompilerActivity : BaseActivity() {
 
  private fun startProcess(view: View, decompiler: String, decompilerIndex: Int) {
 
+ if (!isAvailable(decompiler)) {
+ AlertDialog.Builder(context)
+ .setTitle(getString(R.string.decompilerUnavailable))
+ .setMessage(getString(R.string.decompilerUnavailableExplanation))
+ .setIcon(R.drawable.ic_error_outline_black)
+ .setNegativeButton(android.R.string.ok, null)
+ .show()
+ return
+ }
+
  val inputMap = hashMapOf(
  "shouldIgnoreLibs" to userPreferences.ignoreLibraries,
  "maxAttempts" to userPreferences.maxAttempts,

app/src/main/res/values/strings.xml

@@ -111,6 +111,8 @@
  <string name="startingDexToJar">Starting DEX to JAR Conversion</string>
  <string name="shareSource">Share source</string>
  <string name="deleteSource">Delete source</string>
+ <string name="decompilerUnavailable">Decompiler Unavailable</string>
+ <string name="decompilerUnavailableExplanation">JaDX and Fernflower use newer Java features such as some types of lambda\'s which are not available on pre-N versions of Android.\n\nPlease use CFR instead.</string>
  <string name="deleteSourceHistory">Delete source history</string>
  <string name="deleteSourceConfirm">Are you sure you want to delete the decompiled source ?</string>
  <string name="deleteSourceHistoryConfirm">Are you sure you want to delete source history ?</string>