crypto: use async functions for non-stub Promise-returning functions

These were intended to mimic simple async functions, but exceptions thrown in the function body would be returned synchronously, not wrapped in a rejected Promise. PR-URL: #59841 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

Author: Renegade334

lib/internal/crypto/aes.js

@@ -5,7 +5,6 @@ const {
  ArrayBufferPrototypeSlice,
  ArrayFrom,
  ArrayPrototypePush,
- PromiseReject,
  SafeSet,
  TypedArrayPrototypeSlice,
 } = primordials;
@@ -144,7 +143,7 @@ function asyncAesKwCipher(mode, key, data) {
  getVariant('AES-KW', key[kAlgorithm].length)));
 }
 
-function asyncAesGcmCipher(mode, key, data, algorithm) {
+async function asyncAesGcmCipher(mode, key, data, algorithm) {
  const { tagLength = 128 } = algorithm;
 
  const tagByteLength = tagLength / 8;
@@ -160,9 +159,9 @@ function asyncAesGcmCipher(mode, key, data, algorithm) {
  // > If *plaintext* has a length less than *tagLength* bits, then `throw`
  // > an `OperationError`.
  if (tagByteLength > tag.byteLength) {
- return PromiseReject(lazyDOMException(
+ throw lazyDOMException(
  'The provided data is too small.',
- 'OperationError'));
+ 'OperationError');
  }
 
  data = slice(data, 0, -tagByteLength);
@@ -184,7 +183,7 @@ function asyncAesGcmCipher(mode, key, data, algorithm) {
  algorithm.additionalData));
 }
 
-function asyncAesOcbCipher(mode, key, data, algorithm) {
+async function asyncAesOcbCipher(mode, key, data, algorithm) {
  const { tagLength = 128 } = algorithm;
 
  const tagByteLength = tagLength / 8;
@@ -197,9 +196,9 @@ function asyncAesOcbCipher(mode, key, data, algorithm) {
 
  // Similar to GCM, OCB requires the tag to be present for decryption
  if (tagByteLength > tag.byteLength) {
- return PromiseReject(lazyDOMException(
+ throw lazyDOMException(
  'The provided data is too small.',
- 'OperationError'));
+ 'OperationError');
  }
 
  data = slice(data, 0, -tagByteLength);

lib/internal/crypto/cfrg.js

@@ -343,7 +343,7 @@ function cfrgImportKey(
  extractable);
 }
 
-function eddsaSignVerify(key, data, algorithm, signature) {
+async function eddsaSignVerify(key, data, algorithm, signature) {
  const mode = signature === undefined ? kSignJobModeSign : kSignJobModeVerify;
  const type = mode === kSignJobModeSign ? 'private' : 'public';
 

lib/internal/crypto/chacha20_poly1305.js

@@ -4,7 +4,6 @@ const {
  ArrayBufferIsView,
  ArrayBufferPrototypeSlice,
  ArrayFrom,
- PromiseReject,
  SafeSet,
  TypedArrayPrototypeSlice,
 } = primordials;
@@ -47,17 +46,17 @@ function validateKeyLength(length) {
  throw lazyDOMException('Invalid key length', 'DataError');
 }
 
-function c20pCipher(mode, key, data, algorithm) {
+async function c20pCipher(mode, key, data, algorithm) {
  let tag;
  switch (mode) {
  case kWebCryptoCipherDecrypt: {
  const slice = ArrayBufferIsView(data) ?
  TypedArrayPrototypeSlice : ArrayBufferPrototypeSlice;
 
  if (data.byteLength < 16) {
- return PromiseReject(lazyDOMException(
+ throw lazyDOMException(
  'The provided data is too small.',
- 'OperationError'));
+ 'OperationError');
  }
 
  tag = slice(data, -16);

lib/internal/crypto/ec.js

@@ -284,7 +284,7 @@ function ecImportKey(
  extractable);
 }
 
-function ecdsaSignVerify(key, data, { name, hash }, signature) {
+async function ecdsaSignVerify(key, data, { name, hash }, signature) {
  const mode = signature === undefined ? kSignJobModeSign : kSignJobModeVerify;
  const type = mode === kSignJobModeSign ? 'private' : 'public';
 

lib/internal/crypto/ml_dsa.js

@@ -287,7 +287,7 @@ function mlDsaImportKey(
  extractable);
 }
 
-function mlDsaSignVerify(key, data, algorithm, signature) {
+async function mlDsaSignVerify(key, data, algorithm, signature) {
  const mode = signature === undefined ? kSignJobModeSign : kSignJobModeVerify;
  const type = mode === kSignJobModeSign ? 'private' : 'public';
 

lib/internal/crypto/rsa.js

@@ -93,7 +93,7 @@ function validateRsaOaepAlgorithm(algorithm) {
  }
 }
 
-function rsaOaepCipher(mode, key, data, algorithm) {
+async function rsaOaepCipher(mode, key, data, algorithm) {
  validateRsaOaepAlgorithm(algorithm);
 
  const type = mode === kWebCryptoCipherEncrypt ? 'public' : 'private';
@@ -330,7 +330,7 @@ function rsaImportKey(
  }, keyUsages, extractable);
 }
 
-function rsaSignVerify(key, data, { saltLength }, signature) {
+async function rsaSignVerify(key, data, { saltLength }, signature) {
  const mode = signature === undefined ? kSignJobModeSign : kSignJobModeVerify;
  const type = mode === kSignJobModeSign ? 'private' : 'public';
 

lib/internal/crypto/webcrypto.js

@@ -1022,7 +1022,7 @@ async function unwrapKey(
  );
 }
 
-function signVerify(algorithm, key, data, signature) {
+async function signVerify(algorithm, key, data, signature) {
  let usage = 'sign';
  if (signature !== undefined) {
  usage = 'verify';