fix: resolve override conflicts and apply correct versions #8089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
owlstronaut commented Feb 20, 2025
…D' for edge override set inconsistencies
owlstronaut commented Feb 20, 2025
| }) | ||
| | ||
| t.equal(original.canReplaceWith(badReplacement), false, 'different overrides fails') | ||
| t.equal(original.canReplaceWith(equivalentReplacement), true, 'different overrides passes') |
Contributor Author
There was a problem hiding this comment.
behavior change, equivalent can now override
Contributor Author
| @jdalton I'm feeling pretty good about this. Any chance you guys have some capacity to take a look? |
wraithgar approved these changes Feb 26, 2025
Member
| Thanks to everyone who worked on this! Fingers crossed we can do a cli release today and this should be included in it. |
wraithgar changed the title 
Merged
Contributor
| Thank you @owlstronaut! Will sync these up with our wrapper. I'll report back if anything funky happens. |
jdalton added a commit to SocketDev/socket-cli that referenced this pull request Feb 27, 2025
Closed
2 tasks
| Hey @owlstronaut @wraithgar, |
Contributor
11.2.0 -> #8074 |
This was referenced Mar 12, 2025
2 tasks
Contributor
| Causes #8688 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR is to help get #7025 over the line. The community member did a great job the fixes in - this'll be an attempt to get it over the line
References
Related:
#7025 #5850