Merge pull request #50 from MiguelSilvaR/index_parser_bug_keys

Fix in regular index generation paths

Author: jjspiegel

MigrationTools/IndexParser/README.md

@@ -10,6 +10,7 @@ The purpose of this package is to help migrating indexes from MongoDB to Oracle
 See: [Oracle Database API for MongoDB](https://docs.oracle.com/en/database/oracle/mongodb-api/mgapi/oracle-database-api-mongodb.pdf)
 * This package will scan all your data and suggest SQL indexes to create based on a combination of your MongoDB index definitions and the actual data types used.
 * If your data is large, running this package may take some time as it must scan all of your collection data. 
+* Package must be used in the same schema as the collection where indexes are going to be used.
 
 ## Installation
 
@@ -72,7 +73,7 @@ If your Object Store bucket is not public, you must also specify a credential.
 from "INDEXES", json_table(
  json_document, '$' columns (
  collectionName, 
- nested '$.indexes[*]' columns(doc format json path '$')
+ nested '$.indexes[*]' columns(doc clob format json path '$')
  )
 );
 ```
@@ -81,7 +82,7 @@ If your Object Store bucket is not public, you must also specify a credential.
 select ora_idx_parser.getSQLIndexes(collectionName, indexes) as SQL_Idx
 from "INDEXES", json_table(
  json_document, '$' columns (
- collectionName, indexes format json 
+ collectionName, indexes clob format json 
  )
 );
 ```
@@ -93,8 +94,8 @@ Example result:
 ```
  alter session enable parallel ddl;
 
-create index "$ora:shows.summary_1" on shows(
-json_value(data, '$.summary.stringOnly()' error on error null on empty) asc
+create index "$ora:shows.summary_1" on SHOWS(
+json_value(DATA, q'[$."summary".stringOnly()]' error on error null on empty) asc
 , 1) parallel;
 
  alter session disable parallel ddl;

MigrationTools/IndexParser/ora_idx_parser.body.sql

@@ -532,6 +532,42 @@ create or replace package body ora_idx_parser as
  return true;
  end;
 
+ /*
+ *
+ * Method used to sanitize keys used in regular idx, so json_value has the 
+ * correct input
+ * E.g.
+ * $.a".abc => json_value(DATA, q'[$."a\""."abc".stringOnly()]')
+ */
+ function sanitize_key_string(v_key clob)
+ return clob
+ is
+ path_cursor sys_refcursor;
+ arr_elem json_object_t;
+ v_path clob;
+ stmt clob;
+ path clob;
+ begin
+
+ stmt := 'select regexp_substr(path, ''[^.]+'', 1, level) from (select ';
+ stmt := stmt || q'[q'[]' || v_key;
+ stmt := stmt || ']''';
+ stmt := stmt || ' path from dual) connect by level <= length(path)-length(replace(path, ''.''))+1'; 
+
+ open path_cursor for stmt;
+ loop
+ fetch path_cursor into v_path;
+ exit when path_cursor%NOTFOUND;
+
+ path := path || '"' || escapeKeyChars(v_path) || '"';
+ path := path || '.';
+
+ end loop;
+ 
+ 
+ return path;
+ end;
+
  /*
  * Method that returns the SQL form of a simple index
  * i.e. not a TTL or multivalue one
@@ -565,22 +601,21 @@ create or replace package body ora_idx_parser as
 
  jtype := key_types(v_key);
 
- v_key := escapeKeyChars(v_key);
- out_stmt := out_stmt || chr(10) || chr(9) || 'json_value(' || json_data_column || ', ' || q'[q'[$."]' || v_key;
- out_stmt := out_stmt || q'["]';
+ v_key := sanitize_key_string(v_key);
+ out_stmt := out_stmt || chr(10) || chr(9) || 'json_value(' || json_data_column || ', ' || q'[q'[$.]' || v_key;
  case jtype
  when 'string' then
- out_stmt := out_stmt || '.stringOnly()';
+ out_stmt := out_stmt || 'stringOnly()';
  when 'number' then
- out_stmt := out_stmt || '.numberOnly()';
+ out_stmt := out_stmt || 'numberOnly()';
  when 'double' then
- out_stmt := out_stmt || '.numberOnly()';
+ out_stmt := out_stmt || 'numberOnly()';
  when 'timestamp' then
- out_stmt := out_stmt || '.dateTimeOnly()';
+ out_stmt := out_stmt || 'dateTimeOnly()';
  when 'boolean' then
- out_stmt := out_stmt || '.booleanOnly()';
+ out_stmt := out_stmt || 'booleanOnly()';
  when 'binary' then
- out_stmt := out_stmt || '.binaryOnly()';
+ out_stmt := out_stmt || 'binaryOnly()';
  else
  err_count := err_count + 1;
  return '/* Unsupported type ''' || jtype || ''', found in ''' || idx_spec || ''' index spec */';
@@ -912,4 +947,4 @@ create or replace package body ora_idx_parser as
 
 
 end ora_idx_parser; 
-/
+/