STYLE: fix pylint unneeded-not warnings (#49382)

* STYLE: fix pylint unneeded-not warnings * fixup! STYLE: fix pylint unneeded-not warnings * Add __ne__ method to ArrowPeriodType and ArrowIntervalType * fixup! Add __ne__ method to ArrowPeriodType and ArrowIntervalType

Author: Moisan

pandas/core/arrays/arrow/extension_types.py

@@ -35,6 +35,9 @@ def __eq__(self, other):
  else:
  return NotImplemented
 
+ def __ne__(self, other) -> bool:
+ return not self == other
+
  def __hash__(self) -> int:
  return hash((str(self), self.freq))
 
@@ -91,6 +94,9 @@ def __eq__(self, other):
  else:
  return NotImplemented
 
+ def __ne__(self, other) -> bool:
+ return not self == other
+
  def __hash__(self) -> int:
  return hash((str(self), str(self.subtype), self.closed))
 

pandas/io/formats/style_render.py

@@ -98,7 +98,7 @@ def __init__(
  self.data: DataFrame = data
  self.index: Index = data.index
  self.columns: Index = data.columns
- if not isinstance(uuid_len, int) or not uuid_len >= 0:
+ if not isinstance(uuid_len, int) or uuid_len < 0:
  raise TypeError("``uuid_len`` must be an integer in range [0, 32].")
  self.uuid = uuid or uuid4().hex[: min(32, uuid_len)]
  self.uuid_len = len(self.uuid)

pandas/tests/arrays/interval/test_interval.py

@@ -256,9 +256,9 @@ def test_arrow_extension_type():
 
  assert p1.closed == "left"
  assert p1 == p2
- assert not p1 == p3
+ assert p1 != p3
  assert hash(p1) == hash(p2)
- assert not hash(p1) == hash(p3)
+ assert hash(p1) != hash(p3)
 
 
 @pyarrow_skip

pandas/tests/arrays/period/test_arrow_compat.py

@@ -21,9 +21,9 @@ def test_arrow_extension_type():
 
  assert p1.freq == "D"
  assert p1 == p2
- assert not p1 == p3
+ assert p1 != p3
  assert hash(p1) == hash(p2)
- assert not hash(p1) == hash(p3)
+ assert hash(p1) != hash(p3)
 
 
 @pytest.mark.parametrize(

pandas/tests/indexes/multi/test_indexing.py

@@ -810,7 +810,7 @@ def test_contains_td64_level(self):
  def test_large_mi_contains(self):
  # GH#10645
  result = MultiIndex.from_arrays([range(10**6), range(10**6)])
- assert not (10**6, 0) in result
+ assert (10**6, 0) not in result
 
 
 def test_timestamp_multiindex_indexer():

pandas/tests/scalar/timedelta/test_arithmetic.py

@@ -1114,5 +1114,5 @@ def test_ops_error_str():
  with pytest.raises(TypeError, match=msg):
  left > right
 
- assert not left == right
+ assert not left == right # pylint: disable=unneeded-not
  assert left != right

pandas/tests/scalar/timestamp/test_comparisons.py

@@ -310,5 +310,5 @@ def __eq__(self, other) -> bool:
  for left, right in [(inf, timestamp), (timestamp, inf)]:
  assert left > right or left < right
  assert left >= right or left <= right
- assert not left == right
+ assert not left == right # pylint: disable=unneeded-not
  assert left != right

pyproject.toml

@@ -90,7 +90,6 @@ disable = [
  "unidiomatic-typecheck",
  "unnecessary-dunder-call",
  "unnecessary-lambda-assignment",
- "unneeded-not",
  "use-implicit-booleaness-not-comparison",
  "use-implicit-booleaness-not-len",
  "wrong-import-order",