MAINT: Adjust the codebase to the new np.array copy keyword meaning

Author: mtsokol

pandas/core/frame.py

@@ -1919,7 +1919,7 @@ def to_numpy(
  dtype = np.dtype(dtype)
  result = self._mgr.as_array(dtype=dtype, copy=copy, na_value=na_value)
  if result.dtype is not dtype:
- result = np.array(result, dtype=dtype, copy=False)
+ result = np.asarray(result, dtype=dtype)
 
  return result
 

pandas/tests/arrays/test_datetimelike.py

@@ -12,6 +12,7 @@
  Timestamp,
 )
 from pandas._libs.tslibs import to_offset
+from pandas.compat.numpy import np_version_gt2
 
 from pandas.core.dtypes.dtypes import PeriodDtype
 
@@ -640,13 +641,14 @@ def test_round(self, arr1d):
 
  def test_array_interface(self, datetime_index):
  arr = datetime_index._data
+ copy_false = None if np_version_gt2 else False
 
  # default asarray gives the same underlying data (for tz naive)
  result = np.asarray(arr)
  expected = arr._ndarray
  assert result is expected
  tm.assert_numpy_array_equal(result, expected)
- result = np.array(arr, copy=False)
+ result = np.array(arr, copy=copy_false)
  assert result is expected
  tm.assert_numpy_array_equal(result, expected)
 
@@ -655,7 +657,7 @@ def test_array_interface(self, datetime_index):
  expected = arr._ndarray
  assert result is expected
  tm.assert_numpy_array_equal(result, expected)
- result = np.array(arr, dtype="datetime64[ns]", copy=False)
+ result = np.array(arr, dtype="datetime64[ns]", copy=copy_false)
  assert result is expected
  tm.assert_numpy_array_equal(result, expected)
  result = np.array(arr, dtype="datetime64[ns]")
@@ -698,6 +700,7 @@ def test_array_tz(self, arr1d):
  # GH#23524
  arr = arr1d
  dti = self.index_cls(arr1d)
+ copy_false = None if np_version_gt2 else False
 
  expected = dti.asi8.view("M8[ns]")
  result = np.array(arr, dtype="M8[ns]")
@@ -706,17 +709,18 @@ def test_array_tz(self, arr1d):
  result = np.array(arr, dtype="datetime64[ns]")
  tm.assert_numpy_array_equal(result, expected)
 
- # check that we are not making copies when setting copy=False
- result = np.array(arr, dtype="M8[ns]", copy=False)
+ # check that we are not making copies when setting copy=copy_false
+ result = np.array(arr, dtype="M8[ns]", copy=copy_false)
  assert result.base is expected.base
  assert result.base is not None
- result = np.array(arr, dtype="datetime64[ns]", copy=False)
+ result = np.array(arr, dtype="datetime64[ns]", copy=copy_false)
  assert result.base is expected.base
  assert result.base is not None
 
  def test_array_i8_dtype(self, arr1d):
  arr = arr1d
  dti = self.index_cls(arr1d)
+ copy_false = None if np_version_gt2 else False
 
  expected = dti.asi8
  result = np.array(arr, dtype="i8")
@@ -725,8 +729,8 @@ def test_array_i8_dtype(self, arr1d):
  result = np.array(arr, dtype=np.int64)
  tm.assert_numpy_array_equal(result, expected)
 
- # check that we are still making copies when setting copy=False
- result = np.array(arr, dtype="i8", copy=False)
+ # check that we are still making copies when setting copy=copy_false
+ result = np.array(arr, dtype="i8", copy=copy_false)
  assert result.base is not expected.base
  assert result.base is None
 
@@ -952,13 +956,14 @@ def test_int_properties(self, timedelta_index, propname):
 
  def test_array_interface(self, timedelta_index):
  arr = timedelta_index._data
+ copy_false = None if np_version_gt2 else False
 
  # default asarray gives the same underlying data
  result = np.asarray(arr)
  expected = arr._ndarray
  assert result is expected
  tm.assert_numpy_array_equal(result, expected)
- result = np.array(arr, copy=False)
+ result = np.array(arr, copy=copy_false)
  assert result is expected
  tm.assert_numpy_array_equal(result, expected)
 
@@ -967,7 +972,7 @@ def test_array_interface(self, timedelta_index):
  expected = arr._ndarray
  assert result is expected
  tm.assert_numpy_array_equal(result, expected)
- result = np.array(arr, dtype="timedelta64[ns]", copy=False)
+ result = np.array(arr, dtype="timedelta64[ns]", copy=copy_false)
  assert result is expected
  tm.assert_numpy_array_equal(result, expected)
  result = np.array(arr, dtype="timedelta64[ns]")

pandas/tests/extension/array_with_attr/array.py

@@ -9,6 +9,8 @@
 
 import numpy as np
 
+from pandas.compat.numpy import np_version_gt2
+
 from pandas.core.dtypes.base import ExtensionDtype
 
 import pandas as pd
@@ -49,6 +51,8 @@ def __init__(self, values, attr=None) -> None:
 
  @classmethod
  def _from_sequence(cls, scalars, *, dtype=None, copy=False):
+ if np_version_gt2 and not copy:
+ copy = None
  data = np.array(scalars, dtype="float64", copy=copy)
  return cls(data)