Skip to content

TST/DOC #10846 Test and document use of SQLAlchemy expressions in read_sql() #10983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2015
Merged

TST/DOC #10846 Test and document use of SQLAlchemy expressions in read_sql() #10983

merged 1 commit into from
Sep 22, 2015

Conversation

@stephenpascoe
Copy link

@stephenpascoe stephenpascoe commented Sep 3, 2015

This provides 2 tests using SQLALchemy expressions to read SQL data into a dataframe and accompanying documentation.

It attempts to address #10846 by explaining how this feature is already supported by pandas.

Closes #10846
@stephenpascoe stephenpascoe mentioned this pull request Sep 3, 2015
Closed
@jreback jreback added Testing pandas testing functions or related to the test suite IO SQL to_sql, read_sql, read_sql_query labels Sep 4, 2015
@jorisvandenbossche jorisvandenbossche added this to the 0.17.0 milestone Sep 22, 2015
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Sep 22, 2015

@stephenpascoe Sorry for the late reply. So this actually already just worked.

Thanks a lot for the tests. And nice docs!

Two questions:

  • Can you squash?
  • Maybe also add to the read_sql/read_sql_query docstrings that it can also accept an SQLAlchemy Select statement
Tests demonstrating how to use sqlalchemy.text() objects in read_sql()
c9476bd 
Documentation describing how to use SQLALchemy Selectable and TextClause objects in read_sql(). Updated read_sql/read_sql_query docstrings.
@stephenpascoe
Copy link
Author

stephenpascoe commented Sep 22, 2015

Squashed, docstrings added and rebased.
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Sep 22, 2015

Thanks a lot!
jorisvandenbossche added a commit that referenced this pull request Sep 22, 2015
@jorisvandenbossche
Merge pull request #10983 from stephenpascoe/issue-10846
1e84f1d 
TST/DOC #10846 Test and document use of SQLAlchemy expressions in read_sql()
@jorisvandenbossche jorisvandenbossche merged commit 1e84f1d into pandas-dev:master Sep 22, 2015
@s-celles s-celles mentioned this pull request Sep 26, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs IO SQL to_sql, read_sql, read_sql_query Testing pandas testing functions or related to the test suite

3 participants

@stephenpascoe @jorisvandenbossche @jreback