GH #14499 Panel.ffill ignores axis parameter and fill along axis=1 #14528
Conversation
pandas/core/generic.py Outdated
| from_dict(result).__finalize__(self) | ||
| new_data = new_obj._data | ||
| | ||
| def test_ffill_bfill_axis(self): |
| handle case where |
Current coverage is 84.65% (diff: 100%)@@ master #14528 diff @@ ========================================== Files 144 144 Lines 51030 51039 +9 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== + Hits 43198 43208 +10 + Misses 7832 7831 -1 Partials 0 0
|
jreback added Bug Missing-data | @jreback you're okay with this pr ? |
doc/source/whatsnew/v0.19.1.txt Outdated
| is not scalar and ``values`` is not specified (:issue:`14380`) | ||
| is not scalar and ``values`` is not specified (:issue:`14380`) | ||
| | ||
| - Bug in ``pd.Panel.ffill`` where ``axis`` was not propagated (:issue:`14499`) |
There was a problem hiding this comment.
Can you move this to the 0.20.0 file? (0.19.1 is released in the meantime)
pandas/tests/test_panel.py Outdated
| panel = self.panel.copy() | ||
| panel['str'] = 'foo' | ||
| | ||
| print(panel) |
| result = dict([(col, s.fillna(method=method, value=value)) | ||
| for col, s in self.iteritems()]) | ||
| if axis == 0: | ||
| frame = self.swapaxes(0, 1) |
There was a problem hiding this comment.
Question (not too familiar with Panels): swapping the axes here can potentially cause dtypes to change? (ints upcast to float, or numeric upcast to object when you have mixed dtypes)
There was a problem hiding this comment.
Good point. Let me check
| @Tux1 can you rebase / update |
| Done … On 22 Dec 2016, at 07:09, Jeff Reback ***@***.***> wrote: @Tux1 <https://github.com/Tux1> can you rebase / update — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14528 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGWku4E3Ck1ncZf0bkgZaE4sGggfblb0ks5rKbGpgaJpZM4KjmbC>. |
| # set the default here, so functions examining the signature | ||
| # can detect if something was set (e.g. in groupby) (GH9221) | ||
| if axis is None: | ||
| axis = 0 |
There was a problem hiding this comment.
axis = self._stat_axis_number give the correct default
| axis2d = 0 | ||
| else: | ||
| frame = self | ||
| axis2d = axis - 1 |
| downcast=downcast) | ||
| if self._is_mixed_type and axis == 1: | ||
| if inplace: | ||
| raise NotImplementedError() |
There was a problem hiding this comment.
add a message to the NotImplementedError
| b0 = a.copy() | ||
| b1 = a.copy() | ||
| b2 = a.copy() | ||
| a['a'].loc[1, 1] = np.nan |
There was a problem hiding this comment.
set using full .loc, not chained indexing, e.g. f0.loc['a', 1, 1] = np.nan
| | ||
| # method='ffill' | ||
| # axis=0 | ||
| assert_panel_equal(a.ffill(axis=0), f0) |
There was a problem hiding this comment.
make these expected before each statement, e.g.
result = a.ffill(axis=0) expected = ...... assert_panel_equal(result, expected) | # method='bfill' | ||
| # axis=2 | ||
| assert_panel_equal(a.bfill(axis=2), b2) | ||
| |
There was a problem hiding this comment.
ideally also tests with a panel that has a non-numeric type as well (IOW, add a string to the above example); this should be a separate set of tests.
| pls comment if youd like to update / rebase and continue |
4 participants
git diff upstream/master | flake8 --diff