DEPR: Patch to_dense behaviour for sparse. #14686
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jreback added API Design Sparse 
Contributor
| lgtm |
1 task
jreback changed the title 
Current coverage is 85.21% (diff: 100%)@@ master #14686 diff @@ ========================================== Files 143 143 Lines 50796 50800 +4 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== + Hits 43285 43288 +3 - Misses 7511 7512 +1 Partials 0 0
|
gfyoung force-pushed the to-dense-patch branch 5 times, most recently from 0c2f535 to 867fe23 Compare 
Patches the following for to_dense: 1) Fix SparseArray.to_dense documentation to refer to SparseArray and not SparseSeries. 2) Deprecate the fill parameter in SparseArray.to_dense, as that parameter was not being respected. 3) Deprecate the sparse_only parameter in SparseSeries.to_dense, as that parameter is inconsistent with the to_dense API we want, which is no parameters. Closes pandas-devgh-14647.
gfyoung force-pushed the to-dense-patch branch from 867fe23 to ad7da32 Compare Contributor
| lgtm. tough travis is not passing. |
Member Author
| @jreback : One of the build machines appears to have broke for a reason unrelated to this PR. Are you able to restart the build on your end? |
Member Author
| @jreback : Everything is passing. Ready to merge if there is nothing else. |
Contributor
| thanks! |
gfyoung added a commit to forking-repos/pandas that referenced this pull request Sep 30, 2018
Also deprecate `fill` in `.get_values` because its parameter was being passed to `.to_dense`, which no longer accepts the `fill` parameter. xref pandas-devgh-14686.
gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 16, 2018
Also deprecate `fill` in `.get_values` because its parameter was being passed to `.to_dense`, which no longer accepts the `fill` parameter. xref pandas-devgh-14686.
gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 18, 2018
Also deprecate `fill` in `.get_values` because its parameter was being passed to `.to_dense`, which no longer accepts the `fill` parameter. xref pandas-devgh-14686.
gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 18, 2018
Also deprecate `fill` in `.get_values` because its parameter was being passed to `.to_dense`, which no longer accepts the `fill` parameter. xref pandas-devgh-14686.
gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 18, 2018
Also deprecate `fill` in `.get_values` because its parameter was being passed to `.to_dense`, which no longer accepts the `fill` parameter. xref pandas-devgh-14686.
jreback pushed a commit that referenced this pull request Oct 18, 2018
Also deprecate `fill` in `.get_values` because its parameter was being passed to `.to_dense`, which no longer accepts the `fill` parameter. xref gh-14686.
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Also deprecate `fill` in `.get_values` because its parameter was being passed to `.to_dense`, which no longer accepts the `fill` parameter. xref pandas-devgh-14686.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Patches the following for
to_dense:Fix
SparseArray.to_densedocumentation to refer toSparseArrayand notSparseSeries.Deprecate the fill parameter in
SparseArray.to_dense, as that parameter was not being respected.Deprecate the sparse_only parameter in
SparseSeries.to_dense, as that parameter is inconsistent with theto_denseAPI we want, which is no parameters.Closes #14647.