BUG: Fix IntervalIndex.to_tuples() with NA values #18757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #18757 +/- ## ========================================== - Coverage 91.63% 91.59% -0.05% ========================================== Files 154 154 Lines 51419 51422 +3 ========================================== - Hits 47120 47102 -18 - Misses 4299 4320 +21
Continue to review full report at Codecov.
|
jreback requested changes Dec 15, 2017
pandas/core/indexes/interval.py Outdated
| return cls.from_arrays(left, right, closed, name=name, copy=False) | ||
| | ||
| def to_tuples(self): | ||
| """Return an Index of tuples of the form (left, right)""" |
Contributor
There was a problem hiding this comment.
I guess would be ok to add a kwarg na_tuple=False here to select behavior as @shoyer suggests.
jschendel force-pushed the iv-idx-tuples branch from 1ec263a to 76f52cd Compare Member Author
| Added the |
jschendel force-pushed the iv-idx-tuples branch from 76f52cd to 7c330c6 Compare jreback approved these changes Dec 15, 2017
Contributor
| thanks @jschendel |
Member
| Indeed, thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff