Add tz param to to_datetime() when utc=True and errors='ignore' #23759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hello @srinivasreddy! Thanks for submitting the PR.
|
mroeschke requested changes Nov 18, 2018
Member
mroeschke left a comment
mroeschke left a comment There was a problem hiding this comment.
Thanks. Needs a test and whatsnew note.
mroeschke reviewed Nov 18, 2018
pandas/core/tools/datetimes.py Outdated
| if errors == 'ignore': | ||
| from pandas import Index | ||
| return Index(result, name=name) | ||
| return Index(result, name=name, tz=tz) |
Member
There was a problem hiding this comment.
While I think this works, we want to avoid passing this directly in the constructor.
Instead, if this line results in a DatetimeIndex, we want to use tz_localize(tz) instead.
Member
| @srinivasreddy do you mind updating and addressing the test failures from the CI? |
Contributor
| closing as stale. if you want to continue pls ping. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff