Skip to content

BUG: DataFrame.loc/iloc fails to update object with new dtype GH24269 #24383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

BUG: DataFrame.loc/iloc fails to update object with new dtype GH24269 #24383

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49df896
BUG: DataFrame.loc/iloc fails to update object with new dtype GH24269
Dec 21, 2018
a78c4b6
Fixing line indent and line length
slnguyen Dec 21, 2018
1ea92e7
updating indent
slnguyen Dec 21, 2018
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pandas/core/indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,17 @@ def can_do_equal_len():
self.obj[item_labels[indexer[info_axis]]] = value
return

if isinstance(value, ABCDataFrame):
Copy link
Contributor

@jreback jreback Dec 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very complicated and likely does not belong here. you would need to heavily comment this and explain line by line.
if (len(indexer) > info_axis and
(is_integer(indexer[info_axis]) or
isinstance(indexer[info_axis], np.ndarray)) and
all(com.is_null_slice(idx)
for i, idx in enumerate(indexer)
if i != info_axis) and
item_labels.is_unique):
self.obj[item_labels[indexer[info_axis]]] = value
return

if isinstance(value, (ABCSeries, dict)):
# TODO(EA): ExtensionBlock.setitem this causes issues with
# setting for extensionarrays that store dicts. Need to decide
Expand Down