Skip to content

avoid non-standard imports #24822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 19, 2019
Merged

avoid non-standard imports #24822

merged 4 commits into from
Jan 19, 2019

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jan 18, 2019

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #24822 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #24822 +/- ## ======================================= Coverage 92.38% 92.38% ======================================= Files 166 166 Lines 52379 52379 ======================================= Hits 48392 48392 Misses 3987 3987
Flag Coverage Δ
#multiple 90.81% <ø> (ø) ⬆️
#single 42.91% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 512830b...e2ac25d. Read the comment docs.
@codecov
Copy link

codecov bot commented Jan 18, 2019 •
edited
Loading

Codecov Report

Merging #24822 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #24822 +/- ## ========================================== - Coverage 92.38% 92.38% -0.01%  ========================================== Files 166 166 Lines 52383 52383 ========================================== - Hits 48396 48395 -1  - Misses 3987 3988 +1
Flag Coverage Δ
#multiple 90.81% <ø> (ø) ⬆️
#single 42.91% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 88.04% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f92c4...c0cbba9. Read the comment docs.
@jreback
Copy link
Contributor

jreback commented Jan 18, 2019

can you add a rule to find these in the 'patterns' section
@jreback jreback added the Testing pandas testing functions or related to the test suite label Jan 18, 2019
@jbrockmendel
Copy link
Member Author

jbrockmendel commented Jan 18, 2019

can you add a rule to find these in the 'patterns' section

There are still 22 files left that do this, so itll take a couple more passes.
@jreback
Copy link
Contributor

jreback commented Jan 18, 2019

would be nice to have a rule - u can comment it out for now that finds these
@jbrockmendel
Copy link
Member Author

jbrockmendel commented Jan 18, 2019

Done
jreback
jreback reviewed Jan 19, 2019
View reviewed changes
ci/code_checks.sh
# Check for imports from pandas.core.common instead of `import pandas.core.common as com`
MSG='Check for non-standard imports' ; echo $MSG
invgrep -R --include="*.py*" -E "from pandas.core.common import " pandas
# invgrep -R --include="*.py*" -E "from numpy import nan " pandas # GH#24822 not yet implemented since the offending imports have not all been removed
Copy link
Contributor

@jreback jreback Jan 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be too distinct, should literally look for something like '[=,\s+]nan[,\s+]' or something like that, but can do in future PR's
@jreback jreback added this to the 0.24.0 milestone Jan 19, 2019
@jreback jreback merged commit 1dcfc5f into pandas-dev:master Jan 19, 2019
@jreback
Copy link
Contributor

jreback commented Jan 19, 2019

thanks
@jbrockmendel jbrockmendel deleted the qtests branch January 19, 2019 22:28
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
avoid non-standard imports (pandas-dev#24822)
4ba6f6a
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
avoid non-standard imports (pandas-dev#24822)
b20a7bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing pandas testing functions or related to the test suite

2 participants

@jbrockmendel @jreback