Skip to content

[BUG] Construction of Interval restricted to numeric/ Timestamp/ Timedelta (#23013) #25768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 23, 2019
Merged

[BUG] Construction of Interval restricted to numeric/ Timestamp/ Timedelta (#23013) #25768

merged 3 commits into from
Mar 23, 2019

Conversation

@makbigc
Copy link
Contributor

@makbigc makbigc commented Mar 18, 2019

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #25768 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #25768 +/- ## ======================================= Coverage 91.25% 91.25% ======================================= Files 172 172 Lines 52965 52965 ======================================= Hits 48335 48335 Misses 4630 4630
Flag Coverage Δ
#multiple 89.83% <ø> (ø) ⬆️
#single 41.74% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d951d...4a59b6e. Read the comment docs.
@codecov
Copy link

codecov bot commented Mar 18, 2019 •
edited
Loading

Codecov Report

Merging #25768 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #25768 +/- ## ========================================== + Coverage 91.27% 91.27% +<.01%  ========================================== Files 173 173 Lines 53002 53002 ========================================== + Hits 48375 48376 +1  + Misses 4627 4626 -1
Flag Coverage Δ
#multiple 89.83% <ø> (ø) ⬆️
#single 41.76% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 89.4% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdfdd77...df59032. Read the comment docs.
jschendel
jschendel suggested changes Mar 18, 2019
View reviewed changes
Copy link
Member

@jschendel jschendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The issue itself didn't get much discussion, and I'm not sure if everyone will agree on this behavior, so will be interesting to see what comments arise here. I support this change, as it's consistent with what we allow for arrays, and as a result eliminates some weird Interval specific corner cases.
@jschendel jschendel added Dtype Conversions Unexpected or buggy dtype conversions Interval Interval data type labels Mar 18, 2019
@jschendel jschendel added this to the 0.25.0 milestone Mar 18, 2019
@jreback
Copy link
Contributor

jreback commented Mar 19, 2019

pls merge master
@jreback
Copy link
Contributor

jreback commented Mar 22, 2019

lgtm. @jschendel
@jschendel jschendel merged commit 9e27f12 into pandas-dev:master Mar 23, 2019
@jschendel
Copy link
Member

jschendel commented Mar 23, 2019

thanks @makbigc
@makbigc makbigc deleted the bug-fix-GH23013 branch March 24, 2019 08:49
@makbigc makbigc mentioned this pull request Mar 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dtype Conversions Unexpected or buggy dtype conversions Interval Interval data type

3 participants

@makbigc @jreback @jschendel