BUG: Fix Timestamp type checks to work with subclassed datetime (#25851) #25853
move imports to fix import exceptions
- Loading branch information
commit 11a091ab2491a4b78e5bd0b35a03a8fb5d6a5b3c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| # -*- coding: utf-8 -*- | ||
| # flake8: noqa | ||
| | ||
| from .conversion import normalize_date, localize_pydatetime | ||
| from .nattype import NaT, NaTType, iNaT, is_null_datetimelike | ||
| from .np_datetime import OutOfBoundsDatetime | ||
| from .period import Period, IncompatibleFrequency | ||
| from .timestamps import Timestamp | ||
| from .timedeltas import delta_to_nanoseconds, ints_to_pytimedelta, Timedelta | ||
| from .tzconversion import tz_convert_single | ||
| from .c_timestamp import maybe_integer_op_deprecated # isort:skip | ||
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really need this function here? this should not be exposed to the rest of the codebase (or directly imported if it actually is needed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just expose it in timestamp.pyx itself to make it easier to import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was exposed previously, and is only used in
pandas/core/arrays/datetimelike.py._Timestampitself makes use of it, so it has to be inc_timestamp.pyxotherwise we would have a circular import.I can change the import in
datetimelike.pyto directly import it if you want.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry made the comment in the wrong place. yes just import it directly in
dateimelike.pyand don't put it intslibs/__init__.py