CLN: Fix mypy error in 'pandas/tests/computation/test_eval.py' #29007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Added explicit typing annotation for _parsers: Dict[str, Type[BaseExprVisitor]] Also added some import for Dict, Type and BaseExprVisitor
38 tasks
Member
simonjayhawkins left a comment
simonjayhawkins left a comment There was a problem hiding this comment.
@immaxchen Thanks for the PR. changes look good. ci failures are unrelated. see #29008
simonjayhawkins requested changes Oct 16, 2019
Member
simonjayhawkins left a comment
simonjayhawkins left a comment There was a problem hiding this comment.
@immaxchen can you merge master.
…est-eval-mypy-typing-error-gh28926 sync with latest upstream/master
Contributor Author
| Sure, thank you, Simon! |
simonjayhawkins approved these changes Oct 16, 2019
Member
simonjayhawkins left a comment
simonjayhawkins left a comment There was a problem hiding this comment.
@immaxchen lgtm @WillAyd
Member
| Thanks @immaxchen |
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added explicit typing annotation for _parsers: Dict[str, Type[BaseExprVisitor]]
Also added some import for Dict, Type and BaseExprVisitor
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff